Edit report at https://bugs.php.net/bug.php?id=65384&edit=1
ID: 65384 Comment by: ni...@php.net Reported by: ni...@php.net Summary: pg_last_notice test failures Status: Closed Type: Bug Package: PostgreSQL related PHP Version: 5.5.2RC1 Assigned To: yohgaki Block user comment: N Private report: N New Comment: I fixed the 09notice test and applied the changes to PHP 5.5 The Travis build now passes on master (and presumably also 5.5). Previous Comments: ------------------------------------------------------------------------ [2013-08-20 08:49:06] ni...@php.net For anyone interested, the relevant commits are: * https://github.com/php/php-src/commit/e960eebfea1fccbb4a2f030949249d4d1d198728 * https://github.com/php/php-src/commit/7d538cf8dd41a2584c56ec4abfafd738f0fa1e31 > I've only committed the fix. Should I commit the fix to 5.4/5.5? I don't know about 5.4, but this should definitely go into 5.5 as we're also testing that on Travis ;) The 09notice.phpt test is still failing: TEST 5533/12097 [ext/pgsql/tests/09notice.phpt] ========DIFF======== 001+ Cannot find notice message in hash 002+ bool(false) 003+ 001- Notice: pg_query(): %s already a transaction in progress in %s on line %d 002- %s already a transaction in progress ========DONE======== That's also the last failing test on Travis, so once that's fixed we'll *finally* have a working build there :) Thanks for working on this! ------------------------------------------------------------------------ [2013-08-20 05:28:40] yohg...@php.net > Setting error logging message solved issue. Setting error logging level solved issue. ------------------------------------------------------------------------ [2013-08-20 05:27:59] yohg...@php.net It was error logging setting. Setting error logging message solved issue. I've only committed the fix. Should I commit the fix to 5.4/5.5? ------------------------------------------------------------------------ [2013-08-18 07:43:23] yohg...@php.net > Could it just be that they configured client_min_messages=WARNING? Users can set it as SQL command. SET client_min_messages TO WARNING; It may be the reason why this test fails. I'll try to change message level to NOTICE to see if it helps. I'm not sure how NOTIFY command is handled by PostgreSQL, so it might not be related, though. There is request that stores all notice during session. I'll work on this request later. If pgsql module keep all of them, it may consume all available memory. Therefore, configuration for max number of notices recorded will be added. It may help to find out what is going on. ------------------------------------------------------------------------ [2013-08-09 20:35:53] m...@php.net Could it just be that they configured client_min_messages=WARNING? ------------------------------------------------------------------------ The remainder of the comments for this report are too long. To view the rest of the comments, please view the bug report online at https://bugs.php.net/bug.php?id=65384 -- Edit this bug report at https://bugs.php.net/bug.php?id=65384&edit=1
