From: enrik dot berkhan at planb dot de
Operating system: any
PHP version: 4.3.2
PHP Bug Type: PHP options/info functions
Bug description: open_basedir doesn't work for single `/'
Description:
------------
if you set open_basedir = "/" it doesn't work, as it is internally
expanded to "//" in fopen_wrappers.c.
Suggested patch:
*** fopen_wrappers.c.orig Sun Feb 23 23:03:54 2003
--- fopen_wrappers.c Wed Jul 30 17:38:41 2003
***************
*** 131,137 ****
/* Resolve the real path into resolved_name */
if ((expand_filepath(path, resolved_name TSRMLS_CC) != NULL) &&
(expand_filepath(local_open_basedir, resolved_basedir TSRMLS_CC) != NULL))
{
/* Handler for basedirs that end with a / */
! if (basedir[strlen(basedir)-1] == PHP_DIR_SEPARATOR) {
resolved_basedir_len = strlen(resolved_basedir);
resolved_basedir[resolved_basedir_len] = '/';
resolved_basedir[++resolved_basedir_len] = '\0';
--- 131,138 ----
/* Resolve the real path into resolved_name */
if ((expand_filepath(path, resolved_name TSRMLS_CC) != NULL) &&
(expand_filepath(local_open_basedir, resolved_basedir TSRMLS_CC) != NULL))
{
/* Handler for basedirs that end with a / */
! if (basedir[strlen(basedir)-1] == PHP_DIR_SEPARATOR &&
! resolved_basedir[strlen(resolved_basedir)-1] !=
PHP_DIR_SEPARATOR) {
resolved_basedir_len = strlen(resolved_basedir);
resolved_basedir[resolved_basedir_len] = '/';
resolved_basedir[++resolved_basedir_len] = '\0';
***************
*** 139,145 ****
resolved_basedir_len = strlen(resolved_basedir);
}
! if (path[strlen(path)-1] == PHP_DIR_SEPARATOR) {
resolved_name_len = strlen(resolved_name);
resolved_name[resolved_name_len] = '/';
resolved_name[++resolved_name_len] = '\0';
--- 140,147 ----
resolved_basedir_len = strlen(resolved_basedir);
}
! if (path[strlen(path)-1] == PHP_DIR_SEPARATOR &&
! resolved_name[strlen(resolved_name)-1] !=
PHP_DIR_SEPARATOR) {
resolved_name_len =
strlen(resolved_naPHP_DIR_SEPARATORme);
resolved_name[resolved_name_len] = '/';
resolved_name[++resolved_name_len] = '\0';
BTW, why is a literal `/' added to the names, not PHP_DIR_SEPARATOR?
--
Edit bug report at http://bugs.php.net/?id=24873&edit=1
--
Try a CVS snapshot (php4): http://bugs.php.net/fix.php?id=24873&r=trysnapshot4
Try a CVS snapshot (php5): http://bugs.php.net/fix.php?id=24873&r=trysnapshot5
Fixed in CVS: http://bugs.php.net/fix.php?id=24873&r=fixedcvs
Fixed in release: http://bugs.php.net/fix.php?id=24873&r=alreadyfixed
Need backtrace: http://bugs.php.net/fix.php?id=24873&r=needtrace
Try newer version: http://bugs.php.net/fix.php?id=24873&r=oldversion
Not developer issue: http://bugs.php.net/fix.php?id=24873&r=support
Expected behavior: http://bugs.php.net/fix.php?id=24873&r=notwrong
Not enough info: http://bugs.php.net/fix.php?id=24873&r=notenoughinfo
Submitted twice: http://bugs.php.net/fix.php?id=24873&r=submittedtwice
register_globals: http://bugs.php.net/fix.php?id=24873&r=globals
PHP 3 support discontinued: http://bugs.php.net/fix.php?id=24873&r=php3
Daylight Savings: http://bugs.php.net/fix.php?id=24873&r=dst
IIS Stability: http://bugs.php.net/fix.php?id=24873&r=isapi
Install GNU Sed: http://bugs.php.net/fix.php?id=24873&r=gnused
