ID: 27293
Updated by: [EMAIL PROTECTED]
Reported By: nunoplopes at sapo dot pt
-Status: Bogus
+Status: Open
Bug Type: GD related
Operating System: Win XP
PHP Version: 5CVS
New Comment:
from gc.c:
/* {{{ proto bool image2wbmp(resource im [, string filename [, int
threshold]])
Output WBMP image to browser or file */
PHP_FUNCTION(image2wbmp)
So thresold is optional.
Previous Comments:
------------------------------------------------------------------------
[2004-02-19 19:24:37] [EMAIL PROTECTED]
Thank you for taking the time to write to us, but this is not
a bug. Please double-check the documentation available at
http://www.php.net/manual/ and the instructions on how to report
a bug at http://bugs.php.net/how-to-report.php
You need to pass threshold as the 3rd parameter to
image2wbmp() function.
------------------------------------------------------------------------
[2004-02-19 09:58:42] [EMAIL PROTECTED]
Using latest snapshot, it doesn't segfault, but it generates a
warning:
"Warning: image2wbmp(): Invalid threshold value '-1'. It must be
between 0 and 255 in c:\nuno\testing\a.php on line 7"
----------
I'm not a developper, but I think this patch solves the problem:
cvs diff: Diffing .
Index: gd.c
===================================================================
RCS file: /repository/php-src/ext/gd/gd.c,v
retrieving revision 1.286
diff -u -r1.286 gd.c
--- gd.c 17 Feb 2004 21:30:00 -0000 1.286
+++ gd.c 19 Feb 2004 14:58:49 -0000
@@ -1682,7 +1682,7 @@
char *fn = NULL;
FILE *fp;
int argc = ZEND_NUM_ARGS();
- int q = -1, i, t = 1;
+ int q = 0, i, t = 1;
/* The quality parameter for Wbmp stands for the threshold when
called from image2wbmp() */
/* When called from imagewbmp() the quality parameter stands
for the for
eground color. Default: black. */
------------------------------------------------------------------------
[2004-02-17 16:23:55] [EMAIL PROTECTED]
This bug has been fixed in CVS.
Snapshots of the sources are packaged every three hours; this change
will be in the next snapshot. You can grab the snapshot at
http://snaps.php.net/.
Thank you for the report, and for helping us make PHP better.
------------------------------------------------------------------------
[2004-02-17 14:17:00] nunoplopes at sapo dot pt
Description:
------------
image2wbmp is segfaulting with my PHP 5.
Reproduce code:
---------------
<?php
$file = 'php.png';
$image = imagecreatefrompng($file);
header('Content-type: ' . image_type_to_mime_type(IMAGETYPE_WBMP));
image2wbmp($image);
?>
Expected result:
----------------
output the image
Actual result:
--------------
$ gdb php
GNU gdb 2003-09-20-cvs (cygwin-special)
(...)
(gdb) run bug.php
Starting program: /cygdrive/c/php/php.exe bug.php
---Type <return> to continue, or q <return> to quit---
Warning: image2wbmp(): Invalid threshold value '-1'. It must be between
0 and 25
5 in c:\nuno\testing\bug.php on line 7
Program received signal SIGSEGV, Segmentation fault.
0x00000000 in ?? () from
(gdb) bt
#0 0x00000000 in ?? () from
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=27293&edit=1
