ID: 31647
Updated by: [EMAIL PROTECTED]
Reported By: jeff at wecreate dot com
-Status: Verified
+Status: Wont fix
Bug Type: Output Control
Operating System: *
PHP Version: 4CVS, 5CVS (2005-02-10)
New Comment:
I would make the same assuption about the operation of the code,
however I'd imagine that since this functionality has been around for a
while some people actually rely on it. Changing it now would break BC
and cause all sorts of problems.
Previous Comments:
------------------------------------------------------------------------
[2005-02-10 02:22:05] jeff at wecreate dot com
I would assume that in the case where the variables are
identical, the second call would 'overwrite' the value
of the first call.
for example:
<?
$foo = "bar";
$foo = "bar2";
echo $foo;
?>
would result in "bar2".
so I would assume
<?
output_add_rewrite_var("var","a");
output_add_rewrite_var("var","b");
echo '<a href="test.php">test</a>';
?>
would result in: "<a href="test.php?var=b">test</a>".
More to the point, If I call
output_add_rewrite_var("var","a") twice in the same
script, it doesn't make sense that it would add ?
var=a&var=a , it should only add var=a once.
Thanks.
------------------------------------------------------------------------
[2005-01-24 04:43:10] [EMAIL PROTECTED]
So what exactly should happen (in your opinion) when you call this
function twice for same variable?
I don't think we'll "fix" this since there isn't really anything to fix
here. IMO.
------------------------------------------------------------------------
[2005-01-21 21:54:55] jeff at wecreate dot com
Description:
------------
multiple calls to output_add_rewrite_var() with identical vars creates
multiple entries on the link.
Reproduce code:
---------------
output_add_rewrite_var("var","a");
output_add_rewrite_var("var","b");
echo '<a href="test.php">test</a>';
Expected result:
----------------
<a href="test.php?var=b">test</a>
Actual result:
--------------
<a href="test.php?var=a&var=b">test</a>
this is useless as var can only have one value.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=31647&edit=1
