ID: 37671
User updated by: squasar at eternalviper dot net
Reported By: squasar at eternalviper dot net
Status: Assigned
Bug Type: MySQLi related
Operating System: *
PHP Version: 5.1.4
Assigned To: georg
New Comment:
Further note: The given patch only applies to code which
assumes that a BIT field is being used as a flag field (i.e. a
BIT(1) column). For larger BIT fields the patch is
insufficient.
Previous Comments:
------------------------------------------------------------------------
[2006-06-02 05:03:15] squasar at eternalviper dot net
The pasted reproduce code is syntactically incorrect. Here
is the correct version:
<?php
// Assume that $DATABASE is an open MySQLi connection to a
MySQL 5.0.x database
$DATABASE->query( "CREATE TABLE IF NOT EXISTS test_me
( test_col BIT NOT NULL )" );
$DATABASE->query( "INSERT INTO test_me VALUES ( 1 ), ( 0 ),
( 1 ), ( 0 )" );
( $statement = $DATABASE->prepare( "SELECT test_col FROM
test_me" ) );
$statement->execute();
$statement->bind_result( $bits );
while ( $statement->fetch() === TRUE )
debug_zval_dump( $bits );
$statement->close();
?>
------------------------------------------------------------------------
[2006-06-02 05:01:19] squasar at eternalviper dot net
Description:
------------
When attempting to use MySQLi prepared statements with BIT
columns, an "unrecognized column type" error is thrown. Here
is a working patch. I do not know if this is an ideal
implementation:
A working patch:
Index: ext/mysqli/mysqli_api.c
============================================================
=======
RCS file: /repository/php-src/ext/mysqli/mysqli_api.c,v
retrieving revision 1.118.2.22
diff -u -r1.118.2.22 mysqli_api.c
--- ext/mysqli/mysqli_api.c 5 Apr 2006 12:17:08 -0000
1.118.2.22
+++ ext/mysqli/mysqli_api.c 2 Jun 2006 04:59:44 -0000
@@ -303,10 +303,13 @@
break;
case MYSQL_TYPE_LONGLONG:
+#ifdef FIELD_TYPE_BIT
+ case MYSQL_TYPE_BIT:
+#endif
stmt->result.buf[ofs].type =
IS_STRING;
stmt->result.buf[ofs].buflen
= sizeof(my_ulonglong);
stmt->result.buf[ofs].val =
(char *)emalloc(stmt->result.buf[ofs].buflen);
- bind[ofs].buffer_type =
MYSQL_TYPE_LONGLONG;
+ bind[ofs].buffer_type =
col_type;
bind[ofs].buffer = stmt-
>result.buf[ofs].val;
bind[ofs].is_null = &stmt-
>result.is_null[ofs];
bind[ofs].buffer_length =
stmt->result.buf[ofs].buflen;
@@ -713,6 +716,11 @@
}
else {
ZVAL_LONG(stmt->result.vars[i], llval);
}
+#ifdef FIELD_TYPE_BIT
+ } else if
(stmt->stmt->bind[i].buffer_type == MYSQL_TYPE_BIT) {
+
llval = *(my_ulonglong *)stmt->result.buf[i].val;
+
ZVAL_BOOL(stmt->result.vars[i], llval == 0 ? 0 : 1);
+#endif
} else {
ZVAL_STRINGL(stmt->result.vars[i], stmt->result.buf[i].val,
stmt->result.buf[i].buflen, 1);
}
Reproduce code:
---------------
<?php
// Assume that $DATABASE is an open MySQLi connection to a MySQL 5.0.x
database
$DATABASE->query( "CREATE TABLE test( test_col BIT NOT NULL )" );
$DATABASE->query( "INSERT INTO test VALUES ( 1, 0, 1, 0 )" );
$statement = $DATABASE->prepare( "SELECT test_col FROM test" );
$statement->execute();
$statement->bind_result( $bits );
while ( $statement->fetch() === TRUE )
debug_zval_dump( $bits );
$statement->close();
?>
Expected result:
----------------
bool(true) refcount(1)
bool(false) refcount(1)
bool(true) refcount(1)
bool(false) refcount(1)
Actual result:
--------------
Warning: mysqli_stmt::bind_result(): Server returned unknown
type 16. Probably your client library is incompatible with the
server version you use! in - on line 8
NULL refcount(1)
NULL refcount(1)
NULL refcount(1)
NULL refcount(1)
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=37671&edit=1
