ID: 40477
Updated by: [EMAIL PROTECTED]
Reported By: piotrek dot pokora at gmail dot com
Status: Bogus
Bug Type: Variables related
Operating System: debian/linux
PHP Version: 5.2.1
New Comment:
Please use pecl-dev.
Previous Comments:
------------------------------------------------------------------------
[2007-02-14 15:31:25] piotrek dot pokora at gmail dot com
>>Look at mysqli implementation.
>>It DOES NOT contain get_properties hook and works. Why?
>var_dump($mysqli_object);
>Do you see anything? No.
>That's why.
Is it difficult to add posibility to read object's property from its
own read_property hook? This bug is just about this.
The point here is: even I add own get_properties function I can not
update them in object's hash properties scope.
At least it is not done via standard write_property handler.
So I need to use own or standard hooks + additional object's properties
hash table update which duplicates operation.
Of course , get_properties hook can be missed in favour of own
properties registration.
But coming back to mysqli example:
part of object constructor:
zend_object_std_init(&intern->zo, class_type TSRMLS_CC);
zend_hash_copy(intern->zo.properties, &class_type->default_properties,
(copy_ctor_func_t) zval_add_ref,
(void *) &tmp, sizeof(zval *));
The same hash is used by print_r, and doesn't have to be used in read
or write property hook to make those hooks work.
And coming back to this bug summary:
All I report here is the issue of print_r and var_dump which uses
zval.value.obj.properties hash table which doesn't have to be used in
read or write property hooks.
My hook doesn't require hash table value updates, all I need is
object's property name ( hash key in this case ).
print_r and var_dump uses hash table ( only ) so I need to update keys'
values to make these function work.
Why I defined my own hooks? Because print_r or var_dump or any other
OOP featire in ZEND&PHP should respect my hooks.
Right?
If ZEND requires object's properties hash table value updates then I do
not need read property hook as I can get property value from hash
table.
If ZEND requires updated hash table ( with keys and values ) in
function like print_r , how can I avoid setting the same value twice?
Once in write hook and once as hash value?
I can add own get_properties hook. But print_r and var_dump will print
values of properties only ( and only ) when I update hash table which
is not mandatory in read or write property hook.
------------------------------------------------------------------------
[2007-02-14 15:00:22] [EMAIL PROTECTED]
>As it works without get_properties.
Oh, yes it does work, but you can't get the list of properties without
implementing get_properties().
>It's enough to add own read and write property hook
No, it's obviously not enough. See below why.
>Look at mysqli implementation.
>It DOES NOT contain get_properties hook and works. Why?
var_dump($mysqli_object);
Do you see anything? No.
That's why.
------------------------------------------------------------------------
[2007-02-14 14:49:56] piotrek dot pokora at gmail dot com
>Of course get_properties() is required, how else do you >think it
should work?
As it works without get_properties.
It's enough to add own read and write property hook and some function
which "registers" properties of an object in constructor.
It works _perfect_ for reading property, assigning value to it. And the
same for derived classes.
Look at mysqli implementation.
It DOES NOT contain get_properties hook and works. Why?
>You need to know the name of the property to be able to call
>read_property().
Hook function requires zval *member as second argument.
I do not know internals , please tell me :)
read_property hook works _perfect_ without get_properties hook.
>The fact that you can't find any docs for >get_properties()(which is
>implemented quite a number of times in PHP sources) is >hardly a PHP
bug.
Yes, but the logic bug here is the fact that always internal zend
functions "operate" in object's handlers with this little exception of
print_t or var_dump when custom hash table is taken into account.
So , to sum up. I can not find any not working part of code with only
read and write property hook , except this one for print_r and
var_dump.
>Please discuss custom extension writing in >[EMAIL PROTECTED]
mailing list.
Will try :)
------------------------------------------------------------------------
[2007-02-14 11:03:32] [EMAIL PROTECTED]
Of course get_properties() is required, how else do you think it should
work? You need to know the name of the property to be able to call
read_property().
The fact that you can't find any docs for get_properties()(which is
implemented quite a number of times in PHP sources) is hardly a PHP
bug.
Please discuss custom extension writing in [EMAIL PROTECTED]
mailing list.
------------------------------------------------------------------------
[2007-02-14 09:56:01] piotrek dot pokora at gmail dot com
Description:
------------
zend_print_zval_r_ex uses object's get_properties handler and prints
properties HashTable without using read_property handler.
For custom object handlers hooks it means that get_properties should be
also implemented as hook which leads to too much overloaded
implementation as get_properties seems to be invoked for read and write
hooks.
Taking performance into account , one would sacrifice performance
problem for print_r ( which is not used in real production environment
) which could use object's read_property handler hook.
Reproduce code:
---------------
Implement read and write property hooks for object.
Assuming that property's data is set in C extension one is able to
call:
echo $object->prop;
which prints property's value, while
print_r($object);
prints object's properties without values.
I know I can implement own get_properties hook , but unfortunatelly I
can not find suitable docs for such implementation.
I think one should be able to reproduce it with mysqli extension which
implement only get and read property hooks.
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=40477&edit=1
