ID: 40568 User updated by: JPlissonneauDuquene at bellhelicopter dot textr Reported By: JPlissonneauDuquene at bellhelicopter dot textr Status: Open Bug Type: Filesystem function related Operating System: Windows XP PHP Version: 5.2.1 New Comment:
Of course you can fix it the Microsoft way, i.e. in the documentation: "On Windows platforms, file times obtained through stat() filemtime() etc will vary depending on your system's daylight saving time settings. According to Microsoft, 'This is by design.' For further reference see KB190315." But since there is a known API that returns the right information, it would IMO be better to use it rather than do nothing and blame the [insert your expletives here] design. Fixing PHP stat() and co will improve cross-platform compatibility for PHP scripts. Doing nothing will not. PHP already fixed a lot of MS-DOS things, like path separators, so it seems to me that implementing a fix for stat() would remain consistent with that policy. Previous Comments: ------------------------------------------------------------------------ [2007-02-20 22:49:43] [EMAIL PROTECTED] They should fix the design then. And not wrongly implement stuff and make everybody follow their errors. ------------------------------------------------------------------------ [2007-02-20 22:28:59] JPlissonneauDuquene at bellhelicopter dot textr Description: ------------ Hi, PHP filemtime/fileatime/filectime (and maybe stat itself) functions should use GetFileTime() Win32API (or GetFileAttributesEx()), not stat() to retrieve the actual times from files. Otherwise the returned time is shifted by one hour in some conditions. This (mis)behaviour is actually DOCUMENTED by Microsoft, so it does not qualify for "bogus - fix microsoft libraries" bug rejection -- Microsoft already fixed their documentation and even indicated that "This behavior is by design." References: http://support.microsoft.com/kb/158588 http://support.microsoft.com/kb/190315 http://msdn2.microsoft.com/en-gb/library/ms724290.aspx http://us3.php.net/manual/en/function.stat.php#58404 http://www.codeproject.com/datetime/dstbugs.asp Thanks! Reproduce code: --------------- <?php print date(DATE_ISO8601) . ' ' . time() . "\r\n"; $summer_date = gmmktime(12,34,56,06,21,2006); $winter_date = gmmktime(12,34,56,12,21,2006); if (!file_exists("summer_file")) touch("summer_file", $summer_date); if (!file_exists("winter_file")) touch("winter_file", $winter_date); print "summer_file " . $summer_date . ' ' . filemtime("summer_file") . "\r\n"; print "winter_file " . $winter_date . ' ' . filemtime("winter_file") . "\r\n"; ?> Expected result: ---------------- D:\test>php test.php 2007-02-20T15:14:45-0500 1172002485 summer_file 1150893296 1150893296 winter_file 1166704496 1166704496 D:\test>dir 06/21/2006 08:34 AM 0 summer_file 12/21/2006 07:34 AM 0 winter_file Actual result: -------------- # NOTE - run tests in order. Test 1 will create the files. # Do NOT remove the files before tests 2-4. # test 1. Winter time, DST adj. checked D:\test>php test.php 2007-02-20T17:07:47-0500 1172009267 summer_file 1150893296 1150893296 winter_file 1166704496 1166704496 # test 2. Winter time, DST adj. unchecked D:\test>php test.php 2007-02-20T17:08:05-0500 1172009285 summer_file 1150893296 1150896896 winter_file 1166704496 1166704496 # note summer_file timestamp is now 1 hour later # test 3. Summer time, DST adj. unchecked D:\test>php test.php 2007-08-20T18:08:34-0400 1187647714 summer_file 1150893296 1150896896 winter_file 1166704496 1166704496 # same as test 2. # note that time /t or GUI clock will show 17:08, while # PHP time reports 18:08, but this is another bug. # test 4. Summer time, DST adj. now checked D:\test>php test.php 2007-08-20T18:11:04-0400 1187647864 summer_file 1150893296 1150896896 winter_file 1166704496 1166708096 # note that winter_file timestamp is now 1 hour later # time /t and GUI clock jumped 1 hour later (18:11) when # checking automatic DST adj. D:\test>dir *_file # after test1 06/21/2006 08:34 AM 0 summer_file 12/21/2006 07:34 AM 0 winter_file # after test2 06/21/2006 08:34 AM 0 summer_file 12/21/2006 07:34 AM 0 winter_file # after test3 06/21/2006 08:34 AM 0 summer_file 12/21/2006 07:34 AM 0 winter_file # after test4 06/21/2006 09:34 AM 0 summer_file 12/21/2006 08:34 AM 0 winter_file ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=40568&edit=1
