ID: 40947
User updated by: exaton at free dot fr
Reported By: exaton at free dot fr
Status: Open
Bug Type: Filter related
Operating System: WinXP SP2, Debian
PHP Version: 5.2.1
New Comment:
OK damn it, this typo is killing me as well. Responding to myself here
:
It's not that lines 818-819 don't accept an array -- it's that they
ONLY accept an array (because of the || instead of &&). But why test
whether, if the second param IS_LONG, it is an existing ID, then ?
Previous Comments:
------------------------------------------------------------------------
[2007-03-29 12:58:19] exaton at free dot fr
Erm, fine, I can live with using filter_var() instead of
filter_var_array() for this purpose, I'm not a big fan of multiple ways
of doing the same thing anyway.
I would like to get back to lines 818-819 of filter.c, though :
"OK, so those lines say "if the second parameter (op) is a number but
does not refer to an existing filter ID, ***or*** if op is not an
array, then RETURN_FALSE". That should be *and*, not or ! If the second
parameter is not an existing filter ID constant *and* if it is not an
array, then it is not valid."
""IS_LONG && EXISTS" means: The filter ID must be an integer and the ID
must exist. It accpepts array as the filter options/flags/id can be
given as an array, in this case the ID validation is done later."
The fact is, it /does not/ accept an array : || Z_TYPE_PP(op) !=
IS_ARRAY) { RETURN_FALSE; }. I.e., "if the second parameter to
filter_var_array() is not an array, (forgetting whatever else has been
tested just before), then return false". I say again that it should be
--> && Z_TYPE_PP(op) != IS_ARRAY ... :)
Pierre, Re your message at 13:55 UTC, I think that is what has been
missed.
------------------------------------------------------------------------
[2007-03-29 12:55:57] [EMAIL PROTECTED]
Derick, there is no bug here. Please keep it closed.
Or do you have something that I missed?
------------------------------------------------------------------------
[2007-03-29 12:45:19] [EMAIL PROTECTED]
"filter_var_array() certainly does work on an argument => definition
basis, but as the manual states (re. my quote),"
There is a mistake in the manual. It was not thought and implemented to
follow this definition.
The common function is used to filter an array of value with one or
many filters but it is not related to the public API (filter_var and
filter_var_array).
"filter_var_array() certainly does work on an argument => definition
basis, but as the manual states (re. my quote),"
There is BC reason here. The initial code allows or not array of values
(of same type).
"Lines 818-820, within PHP_FUNCTION(filter_var_array), the test
Z_TYPE_PP(op) == IS_LONG && !PHP_FILTER_ID_EXISTS(Z_LVAL_PP(op))
clearly states that op, in essence the second parameter, may be an
integer (that test is next to || Z_TYPE_PP(op) != IS_ARRAY, which
allows...."
"IS_LONG && EXISTS" means: The filter ID must be an integer and the ID
must exist. It accpepts array as the filter options/flags/id can be
given as an array, in this case the ID validation is done later.
In any case, if you provide an invalid filter ID, the complete call is
invalid as your code obviously has a (critical) bug.
"Hey I've found the bug ^^"
Sorry, this is not a bug but the expected behavior :)
If you like to filter an array of values using one filter, please use
filter_var or provide a one definition.
------------------------------------------------------------------------
[2007-03-29 12:39:35] [EMAIL PROTECTED]
Pierre, I believe the function that filters array should return array
by default without any additional flags.
The documentation agrees with me, so something definitely should be
fixed - either the docs or the function.
I prefer fixing the function and Derick said he'll take a look at it.
------------------------------------------------------------------------
[2007-03-29 12:28:32] exaton at free dot fr
Hi Tony, Derick, Pierre-Alain,
Thank you for your extremely speedy feedback on this issue. I believe
that it does still remain, however.
Regarding filter_var($a, FILTER_VALIDATE_INT, FILTER_REQUIRE_ARRAY) :
that is indeed the second piece of code that I presented, to illustrate
the expected result. I had placed the FILTER_REQUIRE_ARRAY flag in an
option array, superfluously but to the same effect, I agree.
filter_var_array() certainly does work on an argument => definition
basis, but as the manual states (re. my quote), "This [second parameter
to the filter_var_array() function] can be also an integer holding a
filter constant. Then all values in the input array are filtered by this
filter.".
A good look at the underlying code in CVS confirms this. I am looking
at .../php-src/ext/filter/filter.c?revision=1.52.2.38&view=markup and I
see :
Lines 818-820, within PHP_FUNCTION(filter_var_array), the test
Z_TYPE_PP(op) == IS_LONG && !PHP_FILTER_ID_EXISTS(Z_LVAL_PP(op)) clearly
states that op, in essence the second parameter, may be an integer (that
test is next to || Z_TYPE_PP(op) != IS_ARRAY, which allows....
Hey I've found the bug ^^
OK, so those lines say "if the second parameter (op) is a number but
does not refer to an existing filter ID, ***or*** if op is not an array,
then RETURN_FALSE". That should be *and*, not or ! If the second
parameter is not an existing filter ID constant *and* if it is not an
array, then it is not valid.
I was going to follow the rest of the trail, through to
php_filter_array_handler() (called on line 823) and then
php_filter_call() (called on line 649 with FILTER_REQUIRE_ARRAY, hence
the equivalence of the two pieces of PHP code, they converge here)...
but I think that the problem is on line 819, where there should be &&
and not ||.
Thanks again :)
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/40947
--
Edit this bug report at http://bugs.php.net/?id=40947&edit=1
