ID: 41190
Updated by: [EMAIL PROTECTED]
Reported By: nick at marden dot org
Status: Open
Bug Type: Feature/Change Request
Operating System: Linux
PHP Version: 5.2.1
Assigned To: thekid
New Comment:
Unfortunately your patch doesn't apply against current CVS (PHP_5_2)
$ patch < php5-sybase_ct.return_status-and-output_params.patch
patching file php_sybase_ct.h
patching file php_sybase_ct.c
Hunk #3 succeeded at 177 with fuzz 2 (offset 16 lines).
Hunk #4 FAILED at 1044.
Hunk #5 succeeded at 1147 (offset 5 lines).
Hunk #6 succeeded at 1224 (offset 2 lines).
Hunk #7 succeeded at 1265 (offset 2 lines).
Hunk #8 succeeded at 1366 (offset 2 lines).
Hunk #9 succeeded at 1375 (offset 2 lines).
Hunk #10 succeeded at 1520 (offset 2 lines).
Hunk #11 succeeded at 1547 (offset 2 lines).
Hunk #12 succeeded at 1726 (offset 2 lines).
Hunk #13 succeeded at 1849 (offset 2 lines).
Hunk #14 succeeded at 1886 (offset 2 lines).
Hunk #15 succeeded at 2003 (offset 2 lines).
Hunk #16 succeeded at 2129 (offset 2 lines).
Hunk #17 succeeded at 2164 (offset 2 lines).
Hunk #18 succeeded at 2368 (offset 2 lines).
1 out of 18 hunks FAILED -- saving rejects to file php_sybase_ct.c.rej
I tried to correct the affected places manually but that lead to
segfaults all over the place.
I'll keep trying:)
Previous Comments:
------------------------------------------------------------------------
[2007-05-22 11:40:50] [EMAIL PROTECTED]
Phew, finally got PHP to compile on Windows. Have just fixed some of
the .phpt tests to also work there and will look into integrating your
patches shortly.
------------------------------------------------------------------------
[2007-04-30 14:58:20] nick at marden dot org
The point of the second patch (specifically the {HOSTNAME} part) isn't
to be a substitute for a gethostname() function - although it would be
nice to have one.
The point is to have the sybct.hostname default to the local hostname
*without any user intervention*, something that is not currently the
case.
The reason I added the {HOSTNAME} support is that in our production
environment we often have multiple servers running PHP and it's nice to
know which one is connecting to Sybase in the case of long-running
queries, etc. So by putting
{HOSTNAME}-serverA
or
{HOSTNAME}-serverB
I give myself a shorthand to determine which process is causing trouble
on the Sybase database.
------------------------------------------------------------------------
[2007-04-30 06:56:59] [EMAIL PROTECTED]
Assigning to myself, I like the first patch but am not sure about the
second - I'd rather like to see a gethostname() function in PHP with
which one could accomplish this in userland.
------------------------------------------------------------------------
[2007-04-25 20:11:45] nick at marden dot org
Description:
------------
I have two patches that I would like to propose for the PHP5 Sybase-CT
module.
The first adds the (very useful) functions sybase_output_params() and
sybase_return_status() functions. The patch is here:
http://www.marden.org/php-sybase-ct/php5-sybase_ct.return_status-and-output_params.patch
and the documentation is here:
http://www.marden.org/php-sybase-ct/return_status-and-output_params.txt
The second patch corrects (IMO) the behavior of sybct.hostname to
default to the hostname of the current system. It also supports
{HOSTNAME} as a substitution variable in the sybct.hostname parameter, a
feature that I have found useful in our server farm. The patch is here:
http://www.marden.org/php-sybase-ct/php-sybase_ct.hostname.patch
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=41190&edit=1
