This commit is causing a lot of leaks (see the test result of xml003.phpt).
Does this really break anything? If so, I want to suggest another patch
pasted below.
Moriyoshi
Index: ext/xml/xml.c
===================================================================
RCS file: /repository/php4/ext/xml/xml.c,v
retrieving revision 1.116
diff -u -r1.116 xml.c
--- ext/xml/xml.c 21 Mar 2003 05:26:56 -0000 1.116
+++ ext/xml/xml.c 24 Mar 2003 21:36:17 -0000
@@ -1131,9 +1131,9 @@
parser->object = *mythis;
/* please leave this commented - or ask [EMAIL PROTECTED] before doing it
(again) */
-#ifdef ZEND_ENGINE_2
+/* #ifdef ZEND_ENGINE_2
zval_add_ref(&parser->object);
-#endif
+#endif */
RETVAL_TRUE;
}
"Sterling Hughes" <[EMAIL PROTECTED]> wrote:
> sterling Fri Mar 21 00:26:56 2003 EDT
>
> Modified files:
> /php4/ext/xml xml.c
> Log:
> This broke the xml extension, and pres2, commented out for now
>
>
> Index: php4/ext/xml/xml.c
> diff -u php4/ext/xml/xml.c:1.115 php4/ext/xml/xml.c:1.116
> --- php4/ext/xml/xml.c:1.115 Tue Mar 18 07:06:04 2003
> +++ php4/ext/xml/xml.c Fri Mar 21 00:26:56 2003
> @@ -17,7 +17,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: xml.c,v 1.115 2003/03/18 12:06:04 ssb Exp $ */
> +/* $Id: xml.c,v 1.116 2003/03/21 05:26:56 sterling Exp $ */
>
> #define IS_EXT_MODULE
>
> @@ -287,11 +287,11 @@
> xml_parser *parser = (xml_parser *)rsrc->ptr;
>
> /* please leave this commented - or ask [EMAIL PROTECTED] before doing it
> (again) */
> -#ifdef ZEND_ENGINE_2
> +/*#ifdef ZEND_ENGINE_2
> if (parser->object) {
> zval_ptr_dtor(&parser->object);
> }
> -#endif
> +#endif */
>
> if (parser->parser) {
> XML_ParserFree(parser->parser);
>
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
