Why create such names?  Where is the advantage?  If you are going to
change it, please just make them aliases, so you can use either.

-Sterling

On Wed, 2003-07-16 at 07:08, Zak Greant wrote:
> zak           Wed Jul 16 07:08:03 2003 EDT
> 
>   Modified files:              
>     /php-src/ext/dbase        dbase.c 
>   Log:
>   Created shorter/sensible key names for dbase_get_header_info
>    * 'decimal places' becomes 'precision'
>    * 'printf format' becomes 'format'
>    * 'record offset' becomes 'offset'
>   
>    BTW No docs have been committed for this function yet, nor is it part of any
>    release. This change should affect no users.
>   
>   
> Index: php-src/ext/dbase/dbase.c
> diff -u php-src/ext/dbase/dbase.c:1.65 php-src/ext/dbase/dbase.c:1.66
> --- php-src/ext/dbase/dbase.c:1.65    Tue Jul 15 14:19:51 2003
> +++ php-src/ext/dbase/dbase.c Wed Jul 16 07:08:03 2003
> @@ -16,7 +16,7 @@
>     +----------------------------------------------------------------------+
>   */
>  
> -/* $Id: dbase.c,v 1.65 2003/07/15 18:19:51 zak Exp $ */
> +/* $Id: dbase.c,v 1.66 2003/07/16 11:08:03 zak Exp $ */
>  
>  #ifdef HAVE_CONFIG_H
>  #include "config.h"
> @@ -793,13 +793,13 @@
>               add_assoc_long(row, "length", cur_f->db_flen);
>               
>               /* number of decimals in field */
> -             add_assoc_long(row, "decimal places", cur_f->db_fdc);
> +             add_assoc_long(row, "precision", cur_f->db_fdc);
>  
>               /* format for printing %s etc */
> -             add_assoc_string(row, "printf format", cur_f->db_format, 1);
> +             add_assoc_string(row, "format", cur_f->db_format, 1);
>               
>               /* offset within record */
> -             add_assoc_long(row, "record offset", cur_f->db_foffset);
> +             add_assoc_long(row, "offset", cur_f->db_foffset);
>       }
>  }
>  /* }}} */
-- 
King's Law of Clues :  Common sense is inversely proportional to the  
academic intelligence of the person concerned.

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to