Am Mon, 2003-08-04 um 04.38 schrieb Zeev Suraski:
> zeev Mon Aug 4 04:38:24 2003 EDT
>
> Modified files:
> /php-src/ext/standard array.c
> Log:
> Fix bug #24652 - Sterling, do you begin to think that maybe it wasn't such
> a good idea?
Nope. Needs only to be fixed once, and the performance gain is
signifigant enough. :)
-Sterling
>
>
> Index: php-src/ext/standard/array.c
> diff -u php-src/ext/standard/array.c:1.236 php-src/ext/standard/array.c:1.237
> --- php-src/ext/standard/array.c:1.236 Thu Jul 24 23:03:26 2003
> +++ php-src/ext/standard/array.c Mon Aug 4 04:38:24 2003
> @@ -21,7 +21,7 @@
> +----------------------------------------------------------------------+
> */
>
> -/* $Id: array.c,v 1.236 2003/07/25 03:03:26 iliaa Exp $ */
> +/* $Id: array.c,v 1.237 2003/08/04 08:38:24 zeev Exp $ */
>
> #include "php.h"
> #include "php_ini.h"
> @@ -2545,7 +2545,7 @@
> if (Z_TYPE_PP(entry) == IS_LONG) {
> zend_hash_index_update(Z_ARRVAL_P(return_value),
> Z_LVAL_PP(entry), &data, sizeof(data), NULL);
> } else if (Z_TYPE_PP(entry) == IS_STRING) {
> - zend_hash_update(Z_ARRVAL_P(return_value), Z_STRVAL_PP(entry),
> Z_STRLEN_PP(entry) + 1, &data, sizeof(data), NULL);
> + zend_symtable_update(Z_ARRVAL_P(return_value),
> Z_STRVAL_PP(entry), Z_STRLEN_PP(entry) + 1, &data, sizeof(data), NULL);
> } else {
> zval_ptr_dtor(&data); /* will free also zval structure */
> php_error_docref(NULL TSRMLS_CC, E_WARNING, "Can only flip
> STRING and INTEGER values!");
--
We all agree on the necessity of compromise. We just can't agree on when
it's necessary to compromise.
- Larry Wall
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
