Ilia, I appreciate your continious effort about QC process. GPC bug in rfc1867.c is not critical one, and I agree with you it is not preferable in the final RC process. I will revert my GPC related patch in a couple of hours.
But, I shoudn't revert an another license related patch as shown below because the license compatibility has priority. +2003-10-25 Rui Hirokawa <[EMAIL PROTECTED]> + + * (PHP_4_3) + ext/mbstring/mbstring.dsp: + fixed windows build. + + * (PHP_4_3) + ext/mbstring/README.libmbfl + ext/mbstring/config.m4 + ext/mbstring/cp932_table.h + ext/mbstring/html_entities.c + ext/mbstring/mbfilter.c + ext/mbstring/mbfilter.h + ext/mbstring/mbfilter_cn.c + ext/mbstring/mbfilter_cn.h + ext/mbstring/mbfilter_ja.c + ext/mbstring/mbfilter_ja.h + ext/mbstring/mbfilter_kr.c + ext/mbstring/mbfilter_kr.h + ext/mbstring/mbfilter_ru.c + ext/mbstring/mbfilter_ru.h + ext/mbstring/mbfilter_tw.c + ext/mbstring/mbfilter_tw.h + ext/mbstring/mbregex.c + ext/mbstring/mbregex.h + ext/mbstring/mbstring.c + ext/mbstring/mbstring.dsp + ext/mbstring/mbstring.h + ext/mbstring/unicode_table.h + ext/mbstring/unicode_table_cn.h + ext/mbstring/unicode_table_ja.h + ext/mbstring/unicode_table_kr.h + ext/mbstring/unicode_table_ru.h + ext/mbstring/unicode_table_tw.h: + mbfilter is replaced with libmbfl to maintain the licence compatibility. + mbregex.[ch] is moved to mbregex/ for the same reason. + On Sun, 26 Oct 2003 00:46:29 -0400 Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: > On October 25, 2003 07:14 pm, Rasmus Lerdorf wrote: > > Ah, thought it was the other patch. However, I wouldn't call the above a > > new feature. That one is a bug fix as it was an oversight to not also > > convert form fields in multipart posts. > > Well, it is a mix of a feature & a bug fix. The bug if we decide to call it > such is by no means critical and 2 days before the release time is not a time > to make any non critical changes simply because there is no time to test > them. rfc1867.c is very sensitive code which previously had a number of > security faults at least 1 directly caused by mbstring related changes. It is > my opinion such changes have no place this late in the release cycle. > > Ilia -- Rui Hirokawa <[EMAIL PROTECTED]> -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
