Hi Derick,
We discussed this with Andrei long time ago.
I cannot remember did we it internally or in unicode list.
I willn't rollback the patch right now, because this will slowdown PHP 6
fixing.
It is hard to see those failures are bugs and those not.
I willn't against other good solution and will rollback patch if it'll
occur.
Right now any test script can be extended with additional section
--UEXPECT--, --UEXPECTF- or --UEXPECTREGEX--, that is uses instead of
--EXPECT-- in unicode mode. If this sections are omitted then regular
--EXPECT-- is used.
In most cases --UEXPECT...-- section can be get from --EXPECT...-- automatic
by replacing 'string(' to 'unicode(' and '["' to '[u"'. This automation is
not always right and it doesn't implemented now.
Any other solutions?
Thanks. Dmitry.
> -----Original Message-----
> From: Derick Rethans [mailto:[EMAIL PROTECTED]
> Sent: Monday, August 15, 2005 11:12 PM
> To: Dmitry Stogov
> Cc: [email protected]
> Subject: Re: [PHP-CVS] cvs: php-src / run-tests.php
> /ext/pdo/tests pdo_001.phptpdo_002.phpt pdo_003.phpt
> pdo_004.phpt pdo_005.phpt pdo_006.phpt
> pdo_007.phptpdo_008.phpt pdo_009.phpt pdo_010.phpt
> pdo_011.phpt pdo_012.phpt pdo_013.phptpdo_014.phpt pdo_015.phpt pdo_
>
>
> On Mon, 15 Aug 2005, Dmitry Stogov wrote:
>
> > /php-src/ext/standard/tests/general_functions getopt.phpt
> > /php-src/ext/standard/tests/strings bug24208.phpt
> bug27278.phpt
> > Log:
> > Test engine is improved to support unicode mode
>
> I would hardly call this an improvement - now we have to ahve two
> "EXPECT" blocks. I think you should have discussed this
> change before -
> now it's a mess IMO. Please revert the changes to the run-tests.php
> script, and let;s discuss what we should do here.
>
> Derick
> --
> Derick Rethans
> http://derickrethans.nl | http://ez.no | http://xdebug.org
>
>
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php