Fixing tests is a solution, but it is not perfect. May be you will found another one?
I think current unicode specific EXPECT parts of tests may be deleted in the future, if we will print IS_STRING as "binary" and IS_UNICODE as "string" in unicode mode. Thanks. Dmitry. > -----Original Message----- > From: Marcus Boerger [mailto:[EMAIL PROTECTED] > Sent: Wednesday, January 18, 2006 12:05 PM > To: Dmitry Stogov > Cc: 'Marcus Boerger'; php-cvs@lists.php.net > Subject: Re: [PHP-CVS] cvs: php-src / run-tests.php > /ext/ctype ctype.c /ext/date php_date.c /ext/date/tests > bug35143.phpt /ext/dom document.c node.c /ext/dom/tests > dom002.phpt dom_set_attr_node.phpt /ext/reflection > php_reflection.c /ext/simplexml simplexml.c > > > Hello Dmitry, > > if that was the problem then we need to fix the tests - or > ensure that the visible files (the ones that doesn't get > deleted) contain the '.u'. > > marcus > > Wednesday, January 18, 2006, 8:45:23 AM, you wrote: > > > Hi Marcus, > > > The problem that most tests with error messages are failed, because > > they expect "filename.php", but got "filename.u.php". > > > Thanks. Dmitry. > > >> -----Original Message----- > >> From: Marcus Boerger [mailto:[EMAIL PROTECTED] > >> Sent: Tuesday, January 17, 2006 11:16 PM > >> To: Dmitry Stogov > >> Cc: php-cvs@lists.php.net > >> Subject: Re: [PHP-CVS] cvs: php-src / run-tests.php > >> /ext/ctype ctype.c /ext/date php_date.c /ext/date/tests > >> bug35143.phpt /ext/dom document.c node.c /ext/dom/tests > >> dom002.phpt dom_set_attr_node.phpt /ext/reflection > >> php_reflection.c /ext/simplexml simplexml.c > >> > >> > >> Hello Dmitry, > >> > >> just a single question, why did you drop $pu for both > >> $test_file and $temp_file? It is needed there for > >> http://gcov.php.net. Care to explain what you were to fix? > >> > >> best regards > >> marcus > >> > >> Tuesday, January 17, 2006, 1:18:54 PM, you wrote: > >> > >> > dmitry Tue Jan 17 12:18:54 2006 UTC > >> > >> > Modified files: > >> > /php-src run-tests.php > >> > /ZendEngine2 zend.c zend.h zend_API.c zend_API.h > >> > zend_builtin_functions.c zend_compile.c > >> > zend_exceptions.c zend_execute.c > >> zend_execute.h > >> > zend_execute_API.c zend_hash.c > zend_hash.h > >> > zend_highlight.c zend_interfaces.c > >> > zend_language_parser.y > >> zend_language_scanner.l > >> > zend_operators.c zend_operators.h > >> zend_unicode.c > >> > zend_unicode.h zend_variables.c > >> zend_vm_def.h > >> > zend_vm_execute.h > >> > /ZendEngine2/tests bug26166.phpt bug28444.phpt > >> > /php-src/ext/ctype ctype.c > >> > /php-src/ext/date php_date.c > >> > /php-src/ext/date/tests bug35143.phpt > >> > /php-src/ext/dom document.c node.c > >> > /php-src/ext/dom/tests dom002.phpt > dom_set_attr_node.phpt > >> > /php-src/ext/reflection php_reflection.c > >> > /php-src/ext/simplexml simplexml.c > >> > /php-src/ext/simplexml/tests 013.phpt profile11.phpt > >> > /php-src/ext/spl php_spl.c spl_array.c spl_iterators.c > >> > /php-src/ext/sqlite sqlite.c > >> > /php-src/ext/standard array.c basic_functions.c > >> file.c math.c md5.c > >> > sha1.c string.c type.c > >> user_filters.c var.c > >> > var_unserializer.re > >> > /php-src/ext/standard/tests/general_functions 008.phpt > >> > /php-src/ext/standard/tests/math bug21523.phpt > >> > /php-src/ext/standard/tests/strings bug22187.phpt > >> strval.phpt > >> > /php-src/ext/tokenizer/tests 002.phpt 003.phpt > >> bug26463.phpt > >> > /php-src/ext/xml xml.c > >> > /php-src/main main.c output.c php_variables.c > >> > /php-src/main/streams plain_wrapper.c > >> > /php-src/tests/basic bug29971.phpt > >> > /php-src/tests/func 006.phpt > >> > /php-src/tests/lang catchable_error_002.phpt > >> > /php-src/tests/run-test test004.phpt test005.phpt > >> test008.phpt > >> > test008a.phpt > >> > Log: > >> > Unicode stuff is changed according to decision maden on PDM. > >> > Now IS_BINRAY data type is removed and IS_STRING > starts behave as > >> > IS_BINARY in unicode mode. IS_STRING is incompatible with > >> IS_UNICODE, > >> > so ALL functions should be improved to support unicode mode. > >> > > >> > > >> > >> > >> Best regards, > >> Marcus > >> > >> > >> > > > > > > Best regards, > Marcus > > > -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
