The unix build isn't using that config option, though.
Nuno
----- Original Message -----
I belive its better to have slower pcre than having php crash left and
right. Stack usage of php-5.1+ is so huge pcre becomes a real stability
issue due.
Edin
Nuno Lopes wrote:
This shouldn't be necessary because of Andrei's patch that allows you to
configure the max recursion depth through a ini setting.
Also, this patch will make pcre much slower (it will do thousands of
malloc's).
Nuno
----- Original Message -----
edink Thu May 18 21:50:51 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/ext/pcre config.w32
Log:
Use heap insted of stack for recursion in hope of avoid stack overflow
crashes
http://cvs.php.net/viewcvs.cgi/php-src/ext/pcre/config.w32?r1=1.4.2.5&r2=1.4.2.5.2.1&diff_format=u
Index: php-src/ext/pcre/config.w32
diff -u php-src/ext/pcre/config.w32:1.4.2.5
php-src/ext/pcre/config.w32:1.4.2.5.2.1
--- php-src/ext/pcre/config.w32:1.4.2.5 Mon Mar 6 22:49:16 2006
+++ php-src/ext/pcre/config.w32 Thu May 18 21:50:51 2006
@@ -1,11 +1,11 @@
-// $Id: config.w32,v 1.4.2.5 2006/03/06 22:49:16 sebastian Exp $
+// $Id: config.w32,v 1.4.2.5.2.1 2006/05/18 21:50:51 edink Exp $
// vim:ft=javascript
ARG_WITH("pcre-regex", "Perl Compatible Regular Expressions", "yes");
if (PHP_PCRE_REGEX == "yes") {
EXTENSION("pcre", "php_pcre.c", PHP_PCRE_REGEX_SHARED,
-
"-DEXPORT= -DNEWLINE=10 -DSUPPORT_UTF8 -DSUPPORT_UCP -DLINK_SIZE=2 -DPOSIX_MALLOC_THRESHOLD=10
-DMATCH_LIMIT=10000000 -DMATCH_LIMIT_RECURSION=10000000 -Iext/pcre/pcrelib");
+
"-DEXPORT= -DNEWLINE=10 -DSUPPORT_UTF8 -DSUPPORT_UCP -DLINK_SIZE=2 -DPOSIX_MALLOC_THRESHOLD=10
-DMATCH_LIMIT=10000000 -DMATCH_LIMIT_RECURSION=10000000 -DNO_RECURSE -Iext/pcre/pcrelib");
ADD_SOURCES("ext/pcre/pcrelib", "pcre_chartables.c
pcre_ucp_searchfuncs.c pcre_compile.c pcre_config.c pcre_dfa_exec.c
pcre_exec.c pcre_fullinfo.c pcre_get.c pcre_globals.c pcre_info.c
pcre_maketables.c pcre_ord2utf8.c pcre_refcount.c pcre_study.c
pcre_tables.c pcre_try_flipped.c pcre_valid_utf8.c pcre_version.c
pcre_xclass.c", "pcre");
ADD_DEF_FILE("ext\\pcre\\php_pcre.def");
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
