On 6/21/06, Nuno Lopes <[EMAIL PROTECTED]> wrote:
Hi Marcus,

No, it wouldn't have the same effect. The bug is only reproducible when
mmap()'ing empty files, thus the need of the file.
Maybe we can bundle an empty file, if you think it's better.

Or MFH sys_get_temp_dir() ;)

-Hannes



Nuno



> Hello Nuno,
>
>   would an empty data stream result in the same effect? If so
> use that rather than working on a real file.
>
> best regards
> marcus
>
> Tuesday, June 20, 2006, 11:49:16 PM, you wrote:
>
>> nlopess         Tue Jun 20 21:49:16 2006 UTC
>
>>   Modified files:              (Branch: PHP_5_2)
>>     /php-src/ext/standard/tests/file    bug37864.phpt
>>   Log:
>>   make sure the test outputs what we want
>>
>> 
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/tests/file/bug37864.phpt?r1=1.1.2.2&r2=1.1.2.3&diff_format=u
>> Index: php-src/ext/standard/tests/file/bug37864.phpt
>> diff -u php-src/ext/standard/tests/file/bug37864.phpt:1.1.2.2
>> php-src/ext/standard/tests/file/bug37864.phpt:1.1.2.3
>> --- php-src/ext/standard/tests/file/bug37864.phpt:1.1.2.2       Tue Jun
>> 20 19:32:59 2006
>> +++ php-src/ext/standard/tests/file/bug37864.phpt       Tue Jun 20
>> 21:49:16 2006
>> @@ -3,8 +3,10 @@
>>  --FILE--
>>  <?php
>>         $tmpfname = tempnam("/tmp", "emptyfile");
>> -       echo file_get_contents($tmpfname), "done.";
>> +       var_dump(file_get_contents($tmpfname));
>> +       echo "done.\n";
>>         unlink($tmpfname);
>>  ?>
>>  --EXPECT--
>> +string(0) ""
>>  done.
>
>
>
>
> Best regards,
> Marcus

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to