On my 2 32 bit machines the compiler complains about int being used where a non-int or a long value is returned. Changing it to long fixes the problem, this is replicated on gcc 3.4 and 4.0.1

On 21-Jun-06, at 12:08 PM, Michael Wallner wrote:

Ilia Alshanetsky wrote:
iliaa           Wed Jun 21 15:19:24 2006 UTC
  Modified files:              (Branch: PHP_5_2)
    /php-src/ext/bz2    bz2_filter.c   Log:
  Fixed compiler warnings.
http://cvs.php.net/viewvc.cgi/php-src/ext/bz2/bz2_filter.c? r1=1.3.2.2&r2=1.3.2.2.2.1&diff_format=u
Index: php-src/ext/bz2/bz2_filter.c
diff -u php-src/ext/bz2/bz2_filter.c:1.3.2.2 php-src/ext/bz2/ bz2_filter.c:1.3.2.2.2.1
--- php-src/ext/bz2/bz2_filter.c:1.3.2.2        Sun Jan  1 12:50:00 2006
+++ php-src/ext/bz2/bz2_filter.c        Wed Jun 21 15:19:23 2006
@@ -16,7 +16,7 @@
+-------------------------------------------------------------------- --+
 */
 -/* $Id: bz2_filter.c,v 1.3.2.2 2006/01/01 12:50:00 sniper Exp $ */
+/* $Id: bz2_filter.c,v 1.3.2.2.2.1 2006/06/21 15:19:23 iliaa Exp $ */
  #ifdef HAVE_CONFIG_H
 #include "config.h"
@@ -274,7 +274,7 @@
        /* Create this filter */
        data = pecalloc(1, sizeof(php_bz2_filter_data), persistent);
        if (!data) {
- php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating % d bytes.", sizeof(php_bz2_filter_data)); + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Failed allocating % ld bytes.", sizeof(php_bz2_filter_data));
                return NULL;
        }


Hi, I don't know what you're running but here size_t is unsigned int.
It's probably unsigned long on 64bit boxen, so what's this fix about?

Regards,
--
Michael

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php



Ilia Alshanetsky

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to