tony2001 Fri Jun 30 10:52:51 2006 UTC
Modified files:
/php-src/ext/standard filestat.c
Log:
add error messages to disk_free_space() & disk_total_space() (feature request
#37971)
http://cvs.php.net/viewvc.cgi/php-src/ext/standard/filestat.c?r1=1.147&r2=1.148&diff_format=u
Index: php-src/ext/standard/filestat.c
diff -u php-src/ext/standard/filestat.c:1.147
php-src/ext/standard/filestat.c:1.148
--- php-src/ext/standard/filestat.c:1.147 Fri May 19 02:51:18 2006
+++ php-src/ext/standard/filestat.c Fri Jun 30 10:52:51 2006
@@ -16,7 +16,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: filestat.c,v 1.147 2006/05/19 02:51:18 iliaa Exp $ */
+/* $Id: filestat.c,v 1.148 2006/06/30 10:52:51 tony2001 Exp $ */
#include "php.h"
#include "fopen_wrappers.h"
@@ -78,6 +78,10 @@
# endif
#endif
+#ifdef PHP_WIN32
+#include "win32/winutil.h"
+#endif
+
#include "basic_functions.h"
#include "php_filestat.h"
@@ -169,7 +173,10 @@
if (func(Z_STRVAL_PP(path),
&FreeBytesAvailableToCaller,
&TotalNumberOfBytes,
- &TotalNumberOfFreeBytes) == 0) RETURN_FALSE;
+ &TotalNumberOfFreeBytes) == 0) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING,
"%s", php_win_err());
+ RETURN_FALSE;
+ }
/* i know - this is ugly, but i works <[EMAIL
PROTECTED]> */
bytestotal = TotalNumberOfBytes.HighPart *
@@ -180,7 +187,10 @@
else {
if (GetDiskFreeSpace(Z_STRVAL_PP(path),
&SectorsPerCluster, &BytesPerSector,
- &NumberOfFreeClusters, &TotalNumberOfClusters)
== 0) RETURN_FALSE;
+ &NumberOfFreeClusters, &TotalNumberOfClusters)
== 0) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING,
"%s", php_win_err());
+ RETURN_FALSE;
+ }
bytestotal = (double)TotalNumberOfClusters *
(double)SectorsPerCluster * (double)BytesPerSector;
}
}
@@ -199,7 +209,10 @@
}
#else /* WINDOWS, OS/2 */
#if defined(HAVE_SYS_STATVFS_H) && defined(HAVE_STATVFS)
- if (statvfs(Z_STRVAL_PP(path), &buf)) RETURN_FALSE;
+ if (statvfs(Z_STRVAL_PP(path), &buf)) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
strerror(errno));
+ RETURN_FALSE;
+ }
if (buf.f_frsize) {
bytestotal = (((double)buf.f_blocks) * ((double)buf.f_frsize));
} else {
@@ -207,7 +220,10 @@
}
#elif (defined(HAVE_SYS_STATFS_H) || defined(HAVE_SYS_MOUNT_H)) &&
defined(HAVE_STATFS)
- if (statfs(Z_STRVAL_PP(path), &buf)) RETURN_FALSE;
+ if (statfs(Z_STRVAL_PP(path), &buf)) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
strerror(errno));
+ RETURN_FALSE;
+ }
bytestotal = (((double)buf.f_bsize) * ((double)buf.f_blocks));
#endif
#endif /* WINDOWS */
@@ -272,7 +288,10 @@
if (func(Z_STRVAL_PP(path),
&FreeBytesAvailableToCaller,
&TotalNumberOfBytes,
- &TotalNumberOfFreeBytes) == 0) RETURN_FALSE;
+ &TotalNumberOfFreeBytes) == 0) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING,
"%s", php_win_err());
+ RETURN_FALSE;
+ }
/* i know - this is ugly, but i works <[EMAIL
PROTECTED]> */
bytesfree = FreeBytesAvailableToCaller.HighPart *
@@ -283,7 +302,10 @@
else {
if (GetDiskFreeSpace(Z_STRVAL_PP(path),
&SectorsPerCluster, &BytesPerSector,
- &NumberOfFreeClusters, &TotalNumberOfClusters)
== 0) RETURN_FALSE;
+ &NumberOfFreeClusters, &TotalNumberOfClusters)
== 0) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING,
"%s", php_win_err());
+ RETURN_FALSE;
+ }
bytesfree = (double)NumberOfFreeClusters *
(double)SectorsPerCluster * (double)BytesPerSector;
}
}
@@ -302,14 +324,20 @@
}
#else /* WINDOWS, OS/2 */
#if defined(HAVE_SYS_STATVFS_H) && defined(HAVE_STATVFS)
- if (statvfs(Z_STRVAL_PP(path), &buf)) RETURN_FALSE;
+ if (statvfs(Z_STRVAL_PP(path), &buf)) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
strerror(errno));
+ RETURN_FALSE;
+ }
if (buf.f_frsize) {
bytesfree = (((double)buf.f_bavail) * ((double)buf.f_frsize));
} else {
bytesfree = (((double)buf.f_bavail) * ((double)buf.f_bsize));
}
#elif (defined(HAVE_SYS_STATFS_H) || defined(HAVE_SYS_MOUNT_H)) &&
defined(HAVE_STATFS)
- if (statfs(Z_STRVAL_PP(path), &buf)) RETURN_FALSE;
+ if (statfs(Z_STRVAL_PP(path), &buf)) {
+ php_error_docref(NULL TSRMLS_CC, E_WARNING, "%s",
strerror(errno));
+ RETURN_FALSE;
+ }
#ifdef NETWARE
bytesfree = (((double)buf.f_bsize) * ((double)buf.f_bfree));
#else
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
