Hannes, thanks for fixing those. When I made the tests I was wondering why the EXPECTUF wasn't working, why it was broken, but the problem was in the test :)

http://cvs.php.net/viewvc.cgi/php-src/ext/pcre/tests/preg_replace_callback2.phpt?r1=1.2&r2=1.3&diff_format=u
Index: php-src/ext/pcre/tests/preg_replace_callback2.phpt
diff -u php-src/ext/pcre/tests/preg_replace_callback2.phpt:1.2 php-src/ext/pcre/tests/preg_replace_callback2.phpt:1.3 --- php-src/ext/pcre/tests/preg_replace_callback2.phpt:1.2 Mon Jul 3 14:55:49 2006 +++ php-src/ext/pcre/tests/preg_replace_callback2.phpt Mon Jul 3 16:03:39 2006
@@ -22,7 +22,7 @@
var_dump(preg_replace_callback('~\A.~', create_function('$m', 'return strtolower($m[0]);'), 'ABC'));
?>
--EXPECTF--
-Warning: preg_replace_callback(): Unable to call custom replacement function ins %preg_replace_callback2.php on line 8 +Warning: preg_replace_callback(): Unable to call custom replacement function in %spreg_replace_callback2.php on line %d
array(3) {
  [0]=>
  string(12) "'a' 'b3' bcd"

just a note: here you are hiding a bug. Thats why I like to keep the line numbers. The expected line number is 8, but it was printing 17 or something like that. That might be a known bug, but I think it shouldn't be hidden like that.

Nuno
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to