tony2001 Wed Aug 9 10:16:21 2006 UTC
Modified files:
/php-src/ext/oci8 oci8.c
Log:
fix #8112 (Persistent connections misbehave when Apache process times out)
http://cvs.php.net/viewvc.cgi/php-src/ext/oci8/oci8.c?r1=1.311&r2=1.312&diff_format=u
Index: php-src/ext/oci8/oci8.c
diff -u php-src/ext/oci8/oci8.c:1.311 php-src/ext/oci8/oci8.c:1.312
--- php-src/ext/oci8/oci8.c:1.311 Sun Aug 6 14:09:46 2006
+++ php-src/ext/oci8/oci8.c Wed Aug 9 10:16:20 2006
@@ -26,7 +26,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: oci8.c,v 1.311 2006/08/06 14:09:46 tony2001 Exp $ */
+/* $Id: oci8.c,v 1.312 2006/08/09 10:16:20 tony2001 Exp $ */
/* TODO
*
* file://localhost/www/docs/oci10/ociaahan.htm#423823 - implement lob_empty()
with OCI_ATTR_LOBEMPTY
@@ -668,7 +668,7 @@
php_info_print_table_start();
php_info_print_table_row(2, "OCI8 Support", "enabled");
php_info_print_table_row(2, "Version", "1.2.1");
- php_info_print_table_row(2, "Revision", "$Revision: 1.311 $");
+ php_info_print_table_row(2, "Revision", "$Revision: 1.312 $");
sprintf(buf, "%ld", OCI_G(num_persistent));
php_info_print_table_row(2, "Active Persistent Connections", buf);
@@ -1760,6 +1760,17 @@
connection = (php_oci_connection *)le->ptr;
if (connection->used_this_request) {
+ if ((PG(connection_status) & PHP_CONNECTION_TIMEOUT)) {
+ /* call OCIBreak() on timeout to avoid
appearance of deadlocked persistent connections */
+ connection->errcode = PHP_OCI_CALL(OCIBreak,
(connection->svc, connection->err));
+ if (connection->errcode != OCI_SUCCESS) {
+ php_oci_error(connection->err,
connection->errcode TSRMLS_CC);
+ PHP_OCI_HANDLE_ERROR(connection,
connection->errcode);
+ /* OCIBreak() failed. delete the
connection */
+ return 1;
+ }
+ }
+
if (connection->descriptors) {
zend_hash_destroy(connection->descriptors);
efree(connection->descriptors);
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
