On 31.08.2006 12:22, Michael Wallner wrote:
Antony Dovgal wrote:
tony2001 Wed Aug 30 22:52:18 2006 UTC
Modified files:
/php-src/ext/tidy tidy.c
Log:
fix tidy problems caused by returning local static buffers
looks like somebody forgot to MFB this patch..
What problems? It's actually been an optimization attempt, not
a forgotten MFB.
# ./sapi/cli/php -r 'tidy_repair_string("");'
[Thu Aug 31 02:43:25 2006] Script: '-'
---------------------------------------
/local/dev/orig/php-src_head/Zend/zend_variables.h(35) : Block 0x083941B0
status:
/local/dev/orig/php-src_head/Zend/zend_variables.c(40) : Actual location
(location was relayed)
Invalid pointer: ((thread_id=0x00000108) != (expected=0x40528C60))
---------------------------------------
Returning pointer to local static buffer is generally bad idea and it was the
reason for such warnings in ZTS mode.
--
Wbr,
Antony Dovgal
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
