iliaa Fri Sep 22 17:41:09 2006 UTC
Modified files: (Branch: PHP_5_2)
/php-src/sapi/cli php_cli.c
/php-src/sapi/cgi cgi_main.c
Log:
Restore support for unquoted -d options
http://cvs.php.net/viewvc.cgi/php-src/sapi/cli/php_cli.c?r1=1.129.2.13.2.9&r2=1.129.2.13.2.10&diff_format=u
Index: php-src/sapi/cli/php_cli.c
diff -u php-src/sapi/cli/php_cli.c:1.129.2.13.2.9
php-src/sapi/cli/php_cli.c:1.129.2.13.2.10
--- php-src/sapi/cli/php_cli.c:1.129.2.13.2.9 Tue Sep 19 20:33:12 2006
+++ php-src/sapi/cli/php_cli.c Fri Sep 22 17:41:09 2006
@@ -20,7 +20,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: php_cli.c,v 1.129.2.13.2.9 2006/09/19 20:33:12 dmitry Exp $ */
+/* $Id: php_cli.c,v 1.129.2.13.2.10 2006/09/22 17:41:09 iliaa Exp $ */
#include "php.h"
#include "php_globals.h"
@@ -645,12 +645,26 @@
case 'd': {
/* define ini entries on command line */
int len = strlen(php_optarg);
+ char *val;
- if (strchr(php_optarg, '=')) {
- cli_sapi_module.ini_entries =
realloc(cli_sapi_module.ini_entries, ini_entries_len + len + sizeof("\n\0"));
- memcpy(cli_sapi_module.ini_entries +
ini_entries_len, php_optarg, len);
- memcpy(cli_sapi_module.ini_entries +
ini_entries_len + len, "\n\0", sizeof("\n\0"));
- ini_entries_len += len + sizeof("\n\0")
- 2;
+ if ((val = strchr(php_optarg, '='))) {
+ val++;
+ if (!isalnum(*val) && *val != '"' &&
*val != '\'' && *val != '\0') {
+ cli_sapi_module.ini_entries =
realloc(cli_sapi_module.ini_entries, ini_entries_len + len +
sizeof("\"\"\n\0"));
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, php_optarg, (val -
php_optarg));
+ ini_entries_len += (val -
php_optarg);
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, "\"", 1);
+ ini_entries_len++;
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, val, len - (val -
php_optarg));
+ ini_entries_len += len - (val -
php_optarg);
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, "\"\n\0",
sizeof("\"\n\0"));
+ ini_entries_len +=
sizeof("\n\0\"") - 2;
+ } else {
+ cli_sapi_module.ini_entries =
realloc(cli_sapi_module.ini_entries, ini_entries_len + len + sizeof("\n\0"));
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, php_optarg, len);
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len + len, "\n\0",
sizeof("\n\0"));
+ ini_entries_len += len +
sizeof("\n\0") - 2;
+ }
} else {
cli_sapi_module.ini_entries =
realloc(cli_sapi_module.ini_entries, ini_entries_len + len + sizeof("=1\n\0"));
memcpy(cli_sapi_module.ini_entries +
ini_entries_len, php_optarg, len);
http://cvs.php.net/viewvc.cgi/php-src/sapi/cgi/cgi_main.c?r1=1.267.2.15.2.11&r2=1.267.2.15.2.12&diff_format=u
Index: php-src/sapi/cgi/cgi_main.c
diff -u php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.11
php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.12
--- php-src/sapi/cgi/cgi_main.c:1.267.2.15.2.11 Tue Sep 19 20:33:12 2006
+++ php-src/sapi/cgi/cgi_main.c Fri Sep 22 17:41:09 2006
@@ -21,7 +21,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: cgi_main.c,v 1.267.2.15.2.11 2006/09/19 20:33:12 dmitry Exp $ */
+/* $Id: cgi_main.c,v 1.267.2.15.2.12 2006/09/22 17:41:09 iliaa Exp $ */
#include "php.h"
#include "php_globals.h"
@@ -1065,12 +1065,26 @@
case 'd': {
/* define ini entries on command line */
int len = strlen(php_optarg);
+ char *val;
- if (strchr(php_optarg, '=')) {
- cgi_sapi_module.ini_entries =
realloc(cgi_sapi_module.ini_entries, ini_entries_len + len + sizeof("\n\0"));
- memcpy(cgi_sapi_module.ini_entries +
ini_entries_len, php_optarg, len);
- memcpy(cgi_sapi_module.ini_entries +
ini_entries_len + len, "\n\0", sizeof("\n\0"));
- ini_entries_len += len + sizeof("\n\0")
- 2;
+ if ((val = strchr(php_optarg, '='))) {
+ val++;
+ if (!isalnum(*val) && *val != '"' &&
*val != '\'' && *val != '\0') {
+ cli_sapi_module.ini_entries =
realloc(cli_sapi_module.ini_entries, ini_entries_len + len +
sizeof("\"\"\n\0"));
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, php_optarg, (val -
php_optarg));
+ ini_entries_len += (val -
php_optarg);
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, "\"", 1);
+ ini_entries_len++;
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, val, len - (val -
php_optarg));
+ ini_entries_len += len - (val -
php_optarg);
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, "\"\n\0",
sizeof("\"\n\0"));
+ ini_entries_len +=
sizeof("\n\0\"") - 2;
+ } else {
+ cli_sapi_module.ini_entries =
realloc(cli_sapi_module.ini_entries, ini_entries_len + len + sizeof("\n\0"));
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len, php_optarg, len);
+
memcpy(cli_sapi_module.ini_entries + ini_entries_len + len, "\n\0",
sizeof("\n\0"));
+ ini_entries_len += len +
sizeof("\n\0") - 2;
+ }
} else {
cgi_sapi_module.ini_entries =
realloc(cgi_sapi_module.ini_entries, ini_entries_len + len + sizeof("=1\n\0"));
memcpy(cgi_sapi_module.ini_entries +
ini_entries_len, php_optarg, len);
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
