Hello Stefan, hehe, nice solution :-) - the non re2c invocation, it's only bad for debugging, so that why i guess it should be mentioned. But everyone that works on this uses re2c himself anyway. That said wouldn't it make sense to not put debug info into the re2c generated files unless we have --enable-debug active?
best regards marcus Friday, October 27, 2006, 10:35:25 AM, you wrote: > sesser Fri Oct 27 08:35:25 2006 UTC > Modified files: (Branch: PHP_4_4) > /php-src/ext/standard var_unserializer.c > Log: > Manual commit without invoking re2c > > > http://cvs.php.net/viewvc.cgi/php-src/ext/standard/var_unserializer.c?r1=1.18.4.24.2.7&r2=1.18.4.24.2.8&diff_format=u > Index: php-src/ext/standard/var_unserializer.c > diff -u php-src/ext/standard/var_unserializer.c:1.18.4.24.2.7 > php-src/ext/standard/var_unserializer.c:1.18.4.24.2.8 > --- php-src/ext/standard/var_unserializer.c:1.18.4.24.2.7 Wed Aug 9 > 23:29:17 2006 > +++ php-src/ext/standard/var_unserializer.c Fri Oct 27 08:35:25 2006 > @@ -18,7 +18,7 @@ > +----------------------------------------------------------------------+ > */ > > -/* $Id: var_unserializer.c,v 1.18.4.24.2.7 2006/08/09 23:29:17 nlopess Exp $ > */ > +/* $Id: var_unserializer.c,v 1.18.4.24.2.8 2006/10/27 08:35:25 sesser Exp $ > */ > > #include "php.h" > #include "ext/standard/php_var.h" > @@ -958,6 +958,10 @@ > > if (*rval == *rval_ref) return 0; > > + if ((*rval_ref)->refcount > 65500) { > + return 0; > + } > + > if (*rval != NULL) { > zval_ptr_dtor(rval); > } > @@ -1002,6 +1006,10 @@ > return 0; > } > > + if ((*rval_ref)->refcount > 65500) { > + return 0; > + } > + > if (*rval != NULL) { > zval_ptr_dtor(rval); > } Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
