tony2001 Wed Dec 20 15:12:06 2006 UTC
Modified files:
/php-src/ext/pspell pspell.c
Log:
don't reinvent the wheel, use sprintf()
http://cvs.php.net/viewvc.cgi/php-src/ext/pspell/pspell.c?r1=1.53&r2=1.54&diff_format=u
Index: php-src/ext/pspell/pspell.c
diff -u php-src/ext/pspell/pspell.c:1.53 php-src/ext/pspell/pspell.c:1.54
--- php-src/ext/pspell/pspell.c:1.53 Sun Oct 8 13:34:23 2006
+++ php-src/ext/pspell/pspell.c Wed Dec 20 15:12:06 2006
@@ -16,7 +16,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: pspell.c,v 1.53 2006/10/08 13:34:23 bjori Exp $ */
+/* $Id: pspell.c,v 1.54 2006/12/20 15:12:06 tony2001 Exp $ */
#define IS_EXT_MODULE
@@ -747,8 +747,7 @@
zval **conf, **pignore;
int argc;
- int loc = PSPELL_LARGEST_WORD;
- char ignore_str[PSPELL_LARGEST_WORD + 1];
+ char ignore_str[MAX_LENGTH_OF_LONG + 1];
long ignore = 0L;
PspellConfig *config;
@@ -763,23 +762,9 @@
convert_to_long_ex(pignore);
ignore = Z_LVAL_PP(pignore);
- /* The following is a very hackish way to convert a long to a string
- (actually only the numbers 0-999 will get converted properly, but that
should
- be sufficient). If anyone knows of a better way to convert an integer
to a string,
- please, fix it.*/
- ignore_str[loc] = '\0';
- while(ignore > 0){
- if(loc == 0){
- break;
- }
- ignore_str[--loc] = '0' + (ignore % 10);
- ignore /= 10;
- }
- if(ignore_str[loc] == '\0'){
- ignore_str[--loc] = '0';
- }
+ sprintf(ignore_str, "%ld", ignore);
- pspell_config_replace(config, "ignore", &ignore_str[loc]);
+ pspell_config_replace(config, "ignore", ignore_str);
RETURN_TRUE;
}
/* }}} */
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
