Hi Ilia, ----- Original Message ----- From: "Ilia Alshanetsky" Sent: Saturday, January 13, 2007
> iliaa Sat Jan 13 16:32:29 2007 UTC > > Modified files: > /php-src/ext/standard formatted_print.c > Log: > > MFB: Improve validation of argnum, width and precision. > [...] > - php_error_docref(NULL TSRMLS_CC, E_WARNING, "Zero is not a valid argument > number"); > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Argument number must be > greater then zero."); > return NULL; > } > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Width must be greater then > zero and less then %d.", INT_MAX); > + return NULL; > + } > > + php_error_docref(NULL TSRMLS_CC, E_WARNING, "Precision must be greater then > zero and less then %d.", INT_MAX); > + return NULL; > + } > Just a grammar nit-pick, but in those new error messages, "then" should be "than." :-) Also, just noticed the period at the end of the messages, which the vast majority of messages elsewhere don't have, so seems like they should be removed. (I sent a patch a few months ago to remove trailing periods in the few errors that had one, and Hannes just applied it to HEAD; although a few others were added back since then...) IMO, those periods make the full generated warning line look weird, which was also mentioned in Bug #39112. If you want/need patches to save time, let me know... Matt -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
