iliaa           Sat Feb 24 16:23:10 2007 UTC

  Modified files:              (Branch: PHP_5_2)
    /php-src/ext/zip/lib        zip_close.c 
  Log:
  
  Fixed snprintf() usage
  
http://cvs.php.net/viewvc.cgi/php-src/ext/zip/lib/zip_close.c?r1=1.1.2.5&r2=1.1.2.6&diff_format=u
Index: php-src/ext/zip/lib/zip_close.c
diff -u php-src/ext/zip/lib/zip_close.c:1.1.2.5 
php-src/ext/zip/lib/zip_close.c:1.1.2.6
--- php-src/ext/zip/lib/zip_close.c:1.1.2.5     Sat Feb 24 02:17:28 2007
+++ php-src/ext/zip/lib/zip_close.c     Sat Feb 24 16:23:10 2007
@@ -527,13 +527,14 @@
     char *temp;
     int tfd;
     FILE *tfp;
+    int len = strlen(za->zn) + 8;
 
-    if ((temp=(char *)malloc(strlen(za->zn)+8)) == NULL) {
+    if ((temp=(char *)malloc(len)) == NULL) {
        _zip_error_set(&za->error, ZIP_ER_MEMORY, 0);
        return NULL;
     }
 
-    snprintf(temp, sizeof(temp), "%s.XXXXXX", za->zn);
+    snprintf(temp, len, "%s.XXXXXX", za->zn);
 
     if ((tfd=mkstemp(temp)) == -1) {
        _zip_error_set(&za->error, ZIP_ER_TMPOPEN, errno);

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to