jani Tue Jul 24 14:18:47 2007 UTC
Modified files:
/php-src php.ini-dist php.ini-recommended
/php-src/main main.c php_globals.h
Log:
- Changed "display_errors" php.ini option to accept "stderr" as value which
makes the error messages to be outputted to STDERR instead of STDOUT with
CGI and CLI SAPIs.
http://cvs.php.net/viewvc.cgi/php-src/php.ini-dist?r1=1.266&r2=1.267&diff_format=u
Index: php-src/php.ini-dist
diff -u php-src/php.ini-dist:1.266 php-src/php.ini-dist:1.267
--- php-src/php.ini-dist:1.266 Thu Jun 21 09:01:57 2007
+++ php-src/php.ini-dist Tue Jul 24 14:18:47 2007
@@ -256,6 +256,16 @@
; instead (see below). Keeping display_errors enabled on a production web site
; may reveal security information to end users, such as file paths on your Web
; server, your database schema or other information.
+;
+; possible values for display_errors:
+;
+; Off - Do not display any errors
+; stderr - Display errors to STDERR (affects only CGI/CLI binaries!)
+;
+;display_errors = "stderr"
+;
+; stdout (On) - Display errors to STDOUT
+;
display_errors = On
; Even when display_errors is on, errors that occur during PHP's startup
http://cvs.php.net/viewvc.cgi/php-src/php.ini-recommended?r1=1.216&r2=1.217&diff_format=u
Index: php-src/php.ini-recommended
diff -u php-src/php.ini-recommended:1.216 php-src/php.ini-recommended:1.217
--- php-src/php.ini-recommended:1.216 Thu Jun 21 09:01:57 2007
+++ php-src/php.ini-recommended Tue Jul 24 14:18:47 2007
@@ -292,6 +292,18 @@
; instead (see below). Keeping display_errors enabled on a production web site
; may reveal security information to end users, such as file paths on your Web
; server, your database schema or other information.
+;
+; possible values for display_errors:
+;
+; Off - Do not display any errors
+; stderr - Display errors to STDERR (affects only CGI/CLI binaries!)
+; On or stdout - Display errors to STDOUT (default)
+;
+; To output errors to STDERR with CGI/CLI:
+;display_errors = "stderr"
+;
+; Default
+;
display_errors = Off
; Even when display_errors is on, errors that occur during PHP's startup
http://cvs.php.net/viewvc.cgi/php-src/main/main.c?r1=1.739&r2=1.740&diff_format=u
Index: php-src/main/main.c
diff -u php-src/main/main.c:1.739 php-src/main/main.c:1.740
--- php-src/main/main.c:1.739 Tue Jul 24 13:29:39 2007
+++ php-src/main/main.c Tue Jul 24 14:18:47 2007
@@ -18,7 +18,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: main.c,v 1.739 2007/07/24 13:29:39 jani Exp $ */
+/* $Id: main.c,v 1.740 2007/07/24 14:18:47 jani Exp $ */
/* {{{ includes
*/
@@ -332,6 +332,89 @@
}
/* }}} */
+/* {{{ php_get_display_errors_mode() helper function
+ */
+static int php_get_display_errors_mode(char *value, int value_length)
+{
+ int mode;
+
+ if (value_length == 2 && !strcasecmp("on", value)) {
+ mode = PHP_DISPLAY_ERRORS_STDOUT;
+ } else if (value_length == 3 && !strcasecmp("yes", value)) {
+ mode = PHP_DISPLAY_ERRORS_STDOUT;
+ } else if (value_length == 4 && !strcasecmp("true", value)) {
+ mode = PHP_DISPLAY_ERRORS_STDOUT;
+ } else if (value_length == 6 && !strcasecmp(value, "stderr")) {
+ mode = PHP_DISPLAY_ERRORS_STDERR;
+ } else if (value_length == 6 && !strcasecmp(value, "stdout")) {
+ mode = PHP_DISPLAY_ERRORS_STDOUT;
+ } else {
+ mode = atoi(value);
+ if (mode && mode != PHP_DISPLAY_ERRORS_STDOUT && mode !=
PHP_DISPLAY_ERRORS_STDERR) {
+ mode = PHP_DISPLAY_ERRORS_STDOUT;
+ }
+ }
+ return mode;
+}
+/* }}} */
+
+/* {{{ PHP_INI_MH
+ */
+static PHP_INI_MH(OnUpdateDisplayErrors)
+{
+ PG(display_errors) = (zend_bool) php_get_display_errors_mode(new_value,
new_value_length);
+
+ return SUCCESS;
+}
+/* }}} */
+
+/* {{{ PHP_INI_DISP
+ */
+static PHP_INI_DISP(display_errors_mode)
+{
+ int mode, tmp_value_length, cgi_or_cli;
+ char *tmp_value;
+
+ if (type == ZEND_INI_DISPLAY_ORIG && ini_entry->modified) {
+ tmp_value = (ini_entry->orig_value ? ini_entry->orig_value :
NULL );
+ tmp_value_length = ini_entry->orig_value_length;
+ } else if (ini_entry->value) {
+ tmp_value = ini_entry->value;
+ tmp_value_length = ini_entry->value_length;
+ } else {
+ tmp_value = NULL;
+ tmp_value_length = 0;
+ }
+
+ mode = php_get_display_errors_mode(tmp_value, tmp_value_length);
+
+ /* Display 'On' for other SAPIs instead of STDOUT or STDERR */
+ cgi_or_cli = (!strcmp(sapi_module.name, "cli") ||
!strcmp(sapi_module.name, "cgi"));
+
+ switch (mode) {
+ case PHP_DISPLAY_ERRORS_STDERR:
+ if (cgi_or_cli ) {
+ PUTS("STDERR");
+ } else {
+ PUTS("On");
+ }
+ break;
+
+ case PHP_DISPLAY_ERRORS_STDOUT:
+ if (cgi_or_cli ) {
+ PUTS("STDOUT");
+ } else {
+ PUTS("On");
+ }
+ break;
+
+ default:
+ PUTS("Off");
+ break;
+ }
+}
+/* }}} */
+
/*
* Need to be read from the environment (?):
* PHP_AUTO_PREPEND_FILE
@@ -358,7 +441,7 @@
PHP_INI_ENTRY_EX("highlight.string", HL_STRING_COLOR,
PHP_INI_ALL, NULL, php_ini_color_displayer_cb)
STD_PHP_INI_BOOLEAN("asp_tags", "0",
PHP_INI_SYSTEM|PHP_INI_PERDIR, OnUpdateBool,
asp_tags, zend_compiler_globals,
compiler_globals)
- STD_PHP_INI_BOOLEAN("display_errors", "1",
PHP_INI_ALL, OnUpdateBool, display_errors,
php_core_globals, core_globals)
+ STD_PHP_INI_ENTRY_EX("display_errors", "1",
PHP_INI_ALL, OnUpdateDisplayErrors, display_errors,
php_core_globals, core_globals, display_errors_mode)
STD_PHP_INI_BOOLEAN("display_startup_errors", "0", PHP_INI_ALL,
OnUpdateBool, display_startup_errors,
php_core_globals, core_globals)
STD_PHP_INI_BOOLEAN("expose_php", "1",
PHP_INI_SYSTEM, OnUpdateBool, expose_php,
php_core_globals, core_globals)
STD_PHP_INI_ENTRY("docref_root", "",
PHP_INI_ALL, OnUpdateString, docref_root,
php_core_globals, core_globals)
@@ -904,7 +987,14 @@
php_printf("%s<br
/>\n<b>%s</b>: %s in <b>%s</b> on line <b>%d</b><br />\n%s",
STR_PRINT(prepend_string), error_type_str, buffer, error_filename,
error_lineno, STR_PRINT(append_string));
}
} else {
- php_printf("%s\n%s: %s in %s on line
%d\n%s", STR_PRINT(prepend_string), error_type_str, buffer, error_filename,
error_lineno, STR_PRINT(append_string));
+ /* Write CLI/CGI errors to stderr if
display_errors = "stderr" */
+ if ((!strcmp(sapi_module.name, "cli")
|| !strcmp(sapi_module.name, "cgi")) &&
+ PG(display_errors) ==
PHP_DISPLAY_ERRORS_STDERR
+ ) {
+ fprintf(stderr, "%s: %s in %s
on line %d\n", error_type_str, buffer, error_filename, error_lineno);
+ } else {
+ php_printf("%s\n%s: %s in %s on
line %d\n%s", STR_PRINT(prepend_string), error_type_str, buffer,
error_filename, error_lineno, STR_PRINT(append_string));
+ }
}
}
}
http://cvs.php.net/viewvc.cgi/php-src/main/php_globals.h?r1=1.112&r2=1.113&diff_format=u
Index: php-src/main/php_globals.h
diff -u php-src/main/php_globals.h:1.112 php-src/main/php_globals.h:1.113
--- php-src/main/php_globals.h:1.112 Tue Jul 3 10:22:55 2007
+++ php-src/main/php_globals.h Tue Jul 24 14:18:47 2007
@@ -16,7 +16,7 @@
+----------------------------------------------------------------------+
*/
-/* $Id: php_globals.h,v 1.112 2007/07/03 10:22:55 dmitry Exp $ */
+/* $Id: php_globals.h,v 1.113 2007/07/24 14:18:47 jani Exp $ */
#ifndef PHP_GLOBALS_H
#define PHP_GLOBALS_H
@@ -33,7 +33,11 @@
extern ZEND_API struct _php_core_globals core_globals;
#endif
+/* Error display modes */
+#define PHP_DISPLAY_ERRORS_STDOUT 1
+#define PHP_DISPLAY_ERRORS_STDERR 2
+/* Track vars */
#define TRACK_VARS_POST 0
#define TRACK_VARS_GET 1
#define TRACK_VARS_COOKIE 2
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
