Hello Jani, right. Copying the tests is dangerous as people will forget to change all versions simply because they don't see them failing because they don't execute them.
-> +1 on __EXPECT(F|REGEX)?(_(32|64))?__ marcus Tuesday, October 2, 2007, 1:53:44 PM, you wrote: > On Tue, 2007-10-02 at 15:44 +0400, Antony Dovgal wrote: >> On 02.10.2007 15:29, Jani Taskinen wrote: >> > Oh..there was one for 64bit too..of course I missed that one since I >> > tested on 32bit only. Yet another reason to not separate tests.. ;) >> > (EXPECT64 :) >> >> Well, I think of suffixes more and more (test_name_64bit.phpt, >> test_name32bit.phpt). >> It becomes a real issue since the number of tests constantly increases and >> we have >> to parse & execute more and more SKIPIF sections. > Well, as the platform shouldn't matter and same code should be used, > just sometimes it gives different expected result, having separate 32/64 > bit expected result in same script would be more useful than having > multiple copies of tests.. > --Jani > -- > Patches/Donations: http://pecl.php.net/~jani/ Best regards, Marcus -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
