helly Tue Jan 22 20:40:30 2008 UTC Added files: /php-src/ext/simplexml/tests bug37076.phpt
Modified files: /php-src/ext/simplexml simplexml.c Log: - Bugfix #37076 (SimpleXML ignores .=). (felipe, marcus) http://cvs.php.net/viewvc.cgi/php-src/ext/simplexml/simplexml.c?r1=1.248&r2=1.249&diff_format=u Index: php-src/ext/simplexml/simplexml.c diff -u php-src/ext/simplexml/simplexml.c:1.248 php-src/ext/simplexml/simplexml.c:1.249 --- php-src/ext/simplexml/simplexml.c:1.248 Mon Dec 31 07:12:14 2007 +++ php-src/ext/simplexml/simplexml.c Tue Jan 22 20:40:30 2008 @@ -18,7 +18,7 @@ +----------------------------------------------------------------------+ */ -/* $Id: simplexml.c,v 1.248 2007/12/31 07:12:14 sebastian Exp $ */ +/* $Id: simplexml.c,v 1.249 2008/01/22 20:40:30 helly Exp $ */ #ifdef HAVE_CONFIG_H #include "config.h" @@ -719,11 +719,13 @@ name = Z_STRVAL_P(member); node = sxe_get_element_by_name(sxe, node, &name, &type TSRMLS_CC); - if (!node) { - sxe_prop_dim_write(object, member, NULL, 1, 0, &node TSRMLS_CC); - type = SXE_ITER_NONE; - name = NULL; + if (node) { + return NULL; } + sxe_prop_dim_write(object, member, NULL, 1, 0, &node TSRMLS_CC); + type = SXE_ITER_NONE; + name = NULL; + MAKE_STD_ZVAL(return_value); _node_as_zval(sxe, node, return_value, type, name, sxe->iter.nsprefix, sxe->iter.isprefix TSRMLS_CC); @@ -2531,7 +2533,7 @@ { php_info_print_table_start(); php_info_print_table_header(2, "Simplexml support", "enabled"); - php_info_print_table_row(2, "Revision", "$Revision: 1.248 $"); + php_info_print_table_row(2, "Revision", "$Revision: 1.249 $"); php_info_print_table_row(2, "Schema support", #ifdef LIBXML_SCHEMAS_ENABLED "enabled"); http://cvs.php.net/viewvc.cgi/php-src/ext/simplexml/tests/bug37076.phpt?view=markup&rev=1.1 Index: php-src/ext/simplexml/tests/bug37076.phpt +++ php-src/ext/simplexml/tests/bug37076.phpt --TEST-- Bug #37076 (SimpleXML ignores .=) --FILE-- <?php $xml = simplexml_load_string("<root><foo /></root>"); $xml->foo = "foo"; $xml->foo .= "bar"; print $xml->asXML(); ?> ===DONE=== --EXPECT-- <?xml version="1.0"?> <root><foo>foobar</foo></root> ===DONE=== -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php