Well, that'd be quite a magical build system to sneak that RE2C_FLAGS there since no such thing is run when a tarball is created. :)
But to make you have warm fuzzy feeling, I added it like that. --Jani On Wed, 2008-03-26 at 15:52 +0100, Marcus Boerger wrote: > Hello Jani, > > the build system figures out whether one is compiling on a system that > uses a GCC version that supports computed gotos. If so it will set > RE2C_FLAGS to "-g" to enable that. So the genfiles should overwrite this > setting so that the packed tarball does not end up with code generated with > the -g flag on, hence RE2C_FLAGS="" or RE2C_FLAGS="-i" is required. > > marcus > > Wednesday, March 26, 2008, 3:35:05 PM, you wrote: > > > It's the "genfiles" used by people who should REALLY know what they are > > doing since they're the ones creating the release tarballs.. :) > > > What is '-g' ? Huh? '-i' just skips the #line.. directives from the > > file.. > > > --Jani > > > On Wed, 2008-03-26 at 14:44 +0100, Marcus Boerger wrote: > >> Hello Jani, > >> > >> shouldn't the "-i" go into RE2CFLAGS but then how about the "-g" that > >> might have been detected for your system. And another thing is, how do we > >> deal with cases where re2c is not present. Should we a) error out, b) > >> revert, c) ignore? > >> > >> marcus > >> > >> Wednesday, March 26, 2008, 2:35:54 PM, you wrote: > >> > >> > jani Wed Mar 26 13:35:54 2008 UTC > >> > >> > Modified files: (Branch: PHP_5_3) > >> > /php-src genfiles > >> > Log: > >> > - Use the right tool here too > >> > > >> > http://cvs.php.net/viewvc.cgi/php-src/genfiles?r1=1.22.2.2&r2=1.22.2.2.4.1&diff_format=u > >> > Index: php-src/genfiles > >> > diff -u php-src/genfiles:1.22.2.2 php-src/genfiles:1.22.2.2.4.1 > >> > --- php-src/genfiles:1.22.2.2 Tue Nov 8 20:21:47 2005 > >> > +++ php-src/genfiles Wed Mar 26 13:35:54 2008 > >> > @@ -1,6 +1,6 @@ > >> > #! /bin/sh > >> > > >> > -STD='make -f Makefile.frag LEX="flex -L" YACC="bison -y -l" srcdir=Zend > >> > builddir=Zend' > >> > +STD='make -f Makefile.frag RE2C="re2c -i" YACC="bison -y -l" > >> > srcdir=Zend builddir=Zend top_srcdir=.' > >> > > >> > (eval "$STD Zend/zend_language_parser.c Zend/zend_language_scanner.c > >> > Zend/zend_ini_parser.c Zend/zend_ini_scanner.c") > >> > > >> > >> > >> > >> > >> > >> > >> Best regards, > >> Marcus > >> > >> > > > > Best regards, > Marcus > -- Patches/Donations: http://pecl.php.net/~jani/ -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
