Antony Dovgal wrote:
> On 29.04.2009 07:24, Greg Beaver wrote:
>
>> cellog Wed Apr 29 03:24:27 2009 UTC
>>
>> Modified files: (Branch: PHP_5_3)
>> /php-src/ext/phar phar.c phar_internal.h phar_object.c tar.c
>> util.c
>> zip.c
>> Log:
>> MFPECL: fix PECL bug #16338, php_stream_copy_to_stream{,_ex}()
>>
>>
>>
>
> ext/phar/tests/fatal_error_webphar.mem
>
> ==29591== Invalid read of size 8
> ==29591== at 0x693B8A: phar_file_action (phar_object.c:315)
> ==29591== by 0x6956D1: zim_Phar_webPhar (phar_object.c:878)
> ==29591== by 0x9203BE: zend_do_fcall_common_helper_SPEC
> (zend_vm_execute.h:313)
> ==29591== by 0x921103: ZEND_DO_FCALL_BY_NAME_SPEC_HANDLER
> (zend_vm_execute.h:422)
> ==29591== by 0x91F64E: execute (zend_vm_execute.h:104)
> ==29591== by 0x8F08C2: zend_execute_scripts (zend.c:1188)
> ==29591== by 0x87BD7B: php_execute_script (main.c:2166)
> ==29591== by 0x9D691F: main (cgi_main.c:2015)
>
>
Oh good - you can reproduce it! The segfault is not related to the
commit, as you can see from the line in question (line 315 of
phar_file_action is a zval_ptr_dtor of EG(return_value_ptr_ptr), which
has nothing to do with streams).
I found this segfault on my system using apache 2.2 with the test script
and added the fatal_error_webphar test to attempt to reproduce it, but
the test in question passes using cgi on my system. Would you be able
to forward bt + valgrind errors to Dmitry? This is a ZE2 problem that
phar's cleanup triggers, and so I need to know how to rewrite the
cleanup so it doesn't trigger the segfault (or ZE2 needs to be fixed,
whichever is the real problem).
Thanks Tony,
Greg
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
