On Wed, 2009-05-13 at 00:45 +0000, Jani Taskinen wrote: > Log: > - Fixed bug #48247 (PHP crashes on errors during startup)
Looks good for 5.3 to me. One comment though: > cat > $ext_builddir/lib/timelib_config.h <<EOF > #ifdef PHP_WIN32 > # include "config.w32.h" > #else > # include <php_config.h> > #endif > EOF Any issue with this file being committed instead of being generated? - Just to reduce the complexity and number of things that might break. People using the timelib for other purpose should still be able to overwrite this file ... johannes -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php