Pierre,
_please_, don't touch what you don't fully understand, right?
This code is no debug, DBG_RETURN is a macro that is used for tracing
but in case of non-debug builds is just a return. Your ifdef actually
breaks the code!
Don't hesitate to ask the maintainer to fix the code and if you get no
answer from him, then go and _try_ to really fix it.
Andrey
Pierre Joye wrote:
pajoye Thu, 03 Dec 2009 10:41:20 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=291637
Log:
- disable this debug code until it is actually fixed
Changed paths:
U php/php-src/branches/PHP_5_3/ext/mysqlnd/mysqlnd.c
U php/php-src/trunk/ext/mysqlnd/mysqlnd.c
Modified: php/php-src/branches/PHP_5_3/ext/mysqlnd/mysqlnd.c
===================================================================
--- php/php-src/branches/PHP_5_3/ext/mysqlnd/mysqlnd.c 2009-12-03 10:17:58 UTC
(rev 291636)
+++ php/php-src/branches/PHP_5_3/ext/mysqlnd/mysqlnd.c 2009-12-03 10:41:20 UTC
(rev 291637)
@@ -2393,7 +2393,9 @@
if (!conn || plugin_id >= mysqlnd_plugin_count()) {
return NULL;
}
+#if 0
DBG_RETURN((void *)conn + sizeof(MYSQLND) + plugin_id * sizeof(void *));
+#endif
}
/* }}} */
Modified: php/php-src/trunk/ext/mysqlnd/mysqlnd.c
===================================================================
--- php/php-src/trunk/ext/mysqlnd/mysqlnd.c 2009-12-03 10:17:58 UTC (rev
291636)
+++ php/php-src/trunk/ext/mysqlnd/mysqlnd.c 2009-12-03 10:41:20 UTC (rev
291637)
@@ -2393,7 +2393,9 @@
if (!conn || plugin_id >= mysqlnd_plugin_count()) {
return NULL;
}
+#if 0
DBG_RETURN((void *)conn + sizeof(MYSQLND) + plugin_id * sizeof(void *));
+#endif
}
/* }}} */
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
