Hi Kalle!
Thanks for pointing out the warnings!
Am 04.10.2010 13:30, Kalle Sommer Nielsen schrieb:
2010/10/4 Ulf Wendel <u...@php.net>:
uw Mon, 04 Oct 2010 10:58:05 +0000
Revision: http://svn.php.net/viewvc?view=revision&revision=303980
Log:
Fixing compiler warning.
After todays commits, the following new warnings appear on Windows,
and before we had none:
ext\mysqli\mysqli.c(898) : warning C4067: unexpected tokens following
preprocess or directive - expected a newline
Weird how whitespace changes have trigged this warning. I'm puzzled. If
you check my commit, you should find that I have not touched that code:
http://svn.php.net/viewvc/php/php-src/branches/PHP_5_3/ext/mysqli/mysqli.c?r1=303897&r2=303973
http://svn.php.net/viewvc/php/php-src/trunk/ext/mysqli/mysqli.c?r1=303897&r2=303973
I'll apply the fix you proposed in a private mail - thanks!
ext\mysqli\mysqli.c(1091) : warning C4101: 'i' : unreferenced local variable
ext\mysqli\mysqli.c(1090) : warning C4101: 'row' : unreferenced local variable
ext\mysqli\mysqli.c(1092) : warning C4101: 'fields' : unreferenced
local variable
ext\mysqli\mysqli.c(1093) : warning C4101: 'field_len' : unreferenced
local variable
I don't understand that one and I'm not getting it (with VS2008 on Win32).
Allow me to say again that I believe not to have touched that code. It
makes me feel a bit better. Of course the warning itself is not welcome...
ext\mysqli\mysqli_driver.c(155) : warning C4047: 'initializing' :
'int' differs in levels of indirection from 'void *'
Sorry, I don't get that one.
These are all compiled using php-trunk r303980. Since all the mysql
extensions are in sync, I'm sure they appear on PHP_5_3 aswell.
Yes, they are almost in sync.
Also, while you are at it, would you mind killing the ones in mysqlnd aswell?
MySQLnd - oh, that's Andrey's baby :-). I'll check what we can do about
the warnings and what other Windows compiler have to say...
Ulf
--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php
