hi, Yes, it breaks the ABI, please revert this patch.
Maybe another implementation by adding a new function could help, but I'm not sure we need that now in 5.3 either. Cheers, On Mon, Jan 10, 2011 at 5:35 AM, Adam Harvey <ahar...@php.net> wrote: > On 8 January 2011 10:34, Rui Hirokawa <hirok...@php.net> wrote: >> hirokawa Sat, 08 Jan 2011 02:34:33 +0000 >> >> Revision: http://svn.php.net/viewvc?view=revision&revision=307248 >> >> Log: >> MFH: added an option to http_build_query for RFC-3986 >> based url-encoding. > > Somebody should double check me on this, because binary > compatibility's not one of my stronger points, but isn't the change to > the php_url_encode_hash_ex() definition going to break BC in 5.3? > ext/standard/php_http.h is one of the headers we install. > > Adam > > -- > PHP CVS Mailing List (http://www.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > > -- Pierre @pierrejoye | http://blog.thepimp.net | http://www.libgd.org -- PHP CVS Mailing List (http://www.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php
