Hi, Hannes!
Could you also apply this trivial fix to note.dtd on PHP_5_3 branch? I
don't have enough karma to do it myself. Thank you.

Index: branches/PHP_5_3/ext/dom/examples/note.dtd
===================================================================
--- branches/PHP_5_3/ext/dom/examples/note.dtd  (revision 312367)
+++ branches/PHP_5_3/ext/dom/examples/note.dtd  (working copy)
@@ -1,6 +1,6 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!ELEMENT note (to,from,heading,body)>
 <!ELEMENT to (#PCDATA)>
 <!ELEMENT from (#PCDATA)>
 <!ELEMENT heading (#PCDATA)>
-<!ELEMENT body (#PCDATA)>
\ No newline at end of file
+<!ELEMENT body (#PCDATA)>


2011/6/9 Hannes Magnusson <bj...@php.net>:
> Is it actually broken there?
> I just removed the external dependencies so I wouldn't have to wait 5
> minutes for the test to run.
>
> -Hannes
>
> On Thu, Jun 9, 2011 at 11:09, Alexey Shein <con...@gmail.com> wrote:
>> PHP_5_3 version?
>>
>> 2011/6/5 Hannes Magnusson <bj...@php.net>:
>>> bjori                                    Sun, 05 Jun 2011 11:31:18 +0000
>>>
>>> Revision: http://svn.php.net/viewvc?view=revision&revision=311827
>>>
>>> Log:
>>> No need to fetch external files and endless amount of DTDs for this test
>>>
>>> Changed paths:
>>>    U   php/php-src/branches/PHP_5_4/ext/dom/examples/note.dtd
>>>    U   
>>> php/php-src/branches/PHP_5_4/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt
>>>    U   php/php-src/trunk/ext/dom/examples/note.dtd
>>>    U   
>>> php/php-src/trunk/ext/dom/tests/DOMDocument_validate_on_parse_variation.phpt
>>
>> --
>> Regards,
>> Shein Alexey
>>
>



-- 
Regards,
Shein Alexey
Index: branches/PHP_5_3/ext/dom/examples/note.dtd
===================================================================
--- branches/PHP_5_3/ext/dom/examples/note.dtd  (revision 312367)
+++ branches/PHP_5_3/ext/dom/examples/note.dtd  (working copy)
@@ -1,6 +1,6 @@
-<?xml version="1.0" ?>
+<?xml version="1.0" encoding="utf-8" ?>
 <!ELEMENT note (to,from,heading,body)>
 <!ELEMENT to (#PCDATA)>
 <!ELEMENT from (#PCDATA)>
 <!ELEMENT heading (#PCDATA)>
-<!ELEMENT body (#PCDATA)>
\ No newline at end of file
+<!ELEMENT body (#PCDATA)>
-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to