This is broken and clearly wasn't tested.

Need <?php in the SKIPIF section as it executes the code there.

- S
On Jul 20, 2011, at 1:57 PM, Ryan Biesemeyer wrote:

> yaauie                                   Wed, 20 Jul 2011 20:57:17 +0000
> 
> Revision: http://svn.php.net/viewvc?view=revision&revision=313487
> 
> Log:
> update test for bug #55169, don't require the extension in INI
> 
> Bug: https://bugs.php.net/55169 (Assigned) mcrypt_create_iv always fails to 
> gather sufficient random data
> 
> Changed paths:
>    U   php/php-src/branches/PHP_5_3/ext/openssl/tests/bug55169.phpt
>    U   php/php-src/branches/PHP_5_4/ext/openssl/tests/bug55169.phpt
>    U   php/php-src/trunk/ext/openssl/tests/bug55169.phpt
> 
> Modified: php/php-src/branches/PHP_5_3/ext/openssl/tests/bug55169.phpt
> ===================================================================
> --- php/php-src/branches/PHP_5_3/ext/openssl/tests/bug55169.phpt      
> 2011-07-20 19:39:22 UTC (rev 313486)
> +++ php/php-src/branches/PHP_5_3/ext/openssl/tests/bug55169.phpt      
> 2011-07-20 20:57:17 UTC (rev 313487)
> @@ -1,8 +1,6 @@
> --TEST--
> openssl_random_pseudo_bytes test
> https://bugs.php.net/bug.php?id=55169
> ---INI--
> -extension=php_openssl.dll
> --SKIPIF--
> if(!extension_loaded('openssl')) echo 'skip - requires openssl extension'
> --FILE--
> 
> Modified: php/php-src/branches/PHP_5_4/ext/openssl/tests/bug55169.phpt
> ===================================================================
> --- php/php-src/branches/PHP_5_4/ext/openssl/tests/bug55169.phpt      
> 2011-07-20 19:39:22 UTC (rev 313486)
> +++ php/php-src/branches/PHP_5_4/ext/openssl/tests/bug55169.phpt      
> 2011-07-20 20:57:17 UTC (rev 313487)
> @@ -1,8 +1,6 @@
> --TEST--
> openssl_random_pseudo_bytes test
> https://bugs.php.net/bug.php?id=55169
> ---INI--
> -extension=php_openssl.dll
> --SKIPIF--
> if(!extension_loaded('openssl')) echo 'skip - requires openssl extension'
> --FILE--
> 
> Modified: php/php-src/trunk/ext/openssl/tests/bug55169.phpt
> ===================================================================
> --- php/php-src/trunk/ext/openssl/tests/bug55169.phpt 2011-07-20 19:39:22 UTC 
> (rev 313486)
> +++ php/php-src/trunk/ext/openssl/tests/bug55169.phpt 2011-07-20 20:57:17 UTC 
> (rev 313487)
> @@ -1,8 +1,6 @@
> --TEST--
> openssl_random_pseudo_bytes test
> https://bugs.php.net/bug.php?id=55169
> ---INI--
> -extension=php_openssl.dll
> --SKIPIF--
> if(!extension_loaded('openssl')) echo 'skip - requires openssl extension'
> --FILE--
> 
> -- 
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php


--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to