Hello, Arpad,

Could you add XFAIL section to your test since it's failing on all
branches (as can be seen for example here:
http://ci.qa.php.net/job/php-src-trunk-matrix-build/architecture=x86,os=linux-debian-6.0/lastCompletedBuild/testReport/)
or, which is better, fix it :)
Thank you.

2012/1/4 Arpad Ray <ar...@php.net>:
> arpad                                    Tue, 03 Jan 2012 21:47:16 +0000
>
> Revision: http://svn.php.net/viewvc?view=revision&revision=321733
>
> Log:
> add test for #60634
>
> Bug: https://bugs.php.net/60634 (Verified) Segmentation fault when trying to 
> die() in SessionHandler::write()
>
> Changed paths:
>    A   php/php-src/branches/PHP_5_3/ext/session/tests/bug60634.phpt
>    A   php/php-src/branches/PHP_5_4/ext/session/tests/bug60634.phpt
>    A   php/php-src/trunk/ext/session/tests/bug60634.phpt
>
> Added: php/php-src/branches/PHP_5_3/ext/session/tests/bug60634.phpt
> ===================================================================
> --- php/php-src/branches/PHP_5_3/ext/session/tests/bug60634.phpt              
>                   (rev 0)
> +++ php/php-src/branches/PHP_5_3/ext/session/tests/bug60634.phpt        
> 2012-01-03 21:47:16 UTC (rev 321733)
> @@ -0,0 +1,45 @@
> +--TEST--
> +Bug #60634 (Segmentation fault when trying to die() in 
> SessionHandler::write())
> +--INI--
> +session.save_path=
> +session.name=PHPSESSID
> +--SKIPIF--
> +<?php include('skipif.inc'); ?>
> +--FILE--
> +<?php
> +
> +ob_start();
> +
> +function open($save_path, $session_name) {
> +    return true;
> +}
> +
> +function close() {
> +       die("close: goodbye cruel world\n");
> +}
> +
> +function read($id) {
> +       return '';
> +}
> +
> +function write($id, $session_data) {
> +       die("write: goodbye cruel world\n");
> +}
> +
> +function destroy($id) {
> +    return true;
> +}
> +
> +function gc($maxlifetime) {
> +    return true;
> +}
> +
> +session_set_save_handler('open', 'close', 'read', 'write', 'destroy', 'gc');
> +session_start();
> +session_write_close();
> +echo "um, hi\n";
> +
> +?>
> +--EXPECTF--
> +write: goodbye cruel world
> +close: goodbye cruel world
>
> Added: php/php-src/branches/PHP_5_4/ext/session/tests/bug60634.phpt
> ===================================================================
> --- php/php-src/branches/PHP_5_4/ext/session/tests/bug60634.phpt              
>                   (rev 0)
> +++ php/php-src/branches/PHP_5_4/ext/session/tests/bug60634.phpt        
> 2012-01-03 21:47:16 UTC (rev 321733)
> @@ -0,0 +1,45 @@
> +--TEST--
> +Bug #60634 (Segmentation fault when trying to die() in 
> SessionHandler::write())
> +--INI--
> +session.save_path=
> +session.name=PHPSESSID
> +--SKIPIF--
> +<?php include('skipif.inc'); ?>
> +--FILE--
> +<?php
> +
> +ob_start();
> +
> +function open($save_path, $session_name) {
> +    return true;
> +}
> +
> +function close() {
> +       die("close: goodbye cruel world\n");
> +}
> +
> +function read($id) {
> +       return '';
> +}
> +
> +function write($id, $session_data) {
> +       die("write: goodbye cruel world\n");
> +}
> +
> +function destroy($id) {
> +    return true;
> +}
> +
> +function gc($maxlifetime) {
> +    return true;
> +}
> +
> +session_set_save_handler('open', 'close', 'read', 'write', 'destroy', 'gc');
> +session_start();
> +session_write_close();
> +echo "um, hi\n";
> +
> +?>
> +--EXPECTF--
> +write: goodbye cruel world
> +close: goodbye cruel world
>
> Added: php/php-src/trunk/ext/session/tests/bug60634.phpt
> ===================================================================
> --- php/php-src/trunk/ext/session/tests/bug60634.phpt                         
>   (rev 0)
> +++ php/php-src/trunk/ext/session/tests/bug60634.phpt   2012-01-03 21:47:16 
> UTC (rev 321733)
> @@ -0,0 +1,45 @@
> +--TEST--
> +Bug #60634 (Segmentation fault when trying to die() in 
> SessionHandler::write())
> +--INI--
> +session.save_path=
> +session.name=PHPSESSID
> +--SKIPIF--
> +<?php include('skipif.inc'); ?>
> +--FILE--
> +<?php
> +
> +ob_start();
> +
> +function open($save_path, $session_name) {
> +    return true;
> +}
> +
> +function close() {
> +       die("close: goodbye cruel world\n");
> +}
> +
> +function read($id) {
> +       return '';
> +}
> +
> +function write($id, $session_data) {
> +       die("write: goodbye cruel world\n");
> +}
> +
> +function destroy($id) {
> +    return true;
> +}
> +
> +function gc($maxlifetime) {
> +    return true;
> +}
> +
> +session_set_save_handler('open', 'close', 'read', 'write', 'destroy', 'gc');
> +session_start();
> +session_write_close();
> +echo "um, hi\n";
> +
> +?>
> +--EXPECTF--
> +write: goodbye cruel world
> +close: goodbye cruel world
>
>
> --
> PHP CVS Mailing List (http://www.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php



-- 
Regards,
Shein Alexey

--
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to