Hi!

> -     if (d > LONG_MAX) {
> +     if (d >= LONG_MAX) {
>               return (long)(unsigned long) d;
>       }
>       return (long) d;

Could you please explain this one? I thought LONG_MAX is a largest
permissible long value, why when d==LONG_MAX we need to convert?

Also, why this patch - which seems to be a BC break since it exhibits
different behavior on 64-bit systems - needs to be in 5.4?

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

-- 
PHP CVS Mailing List (http://www.php.net/)
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to