On Thu, Feb 7, 2013 at 4:44 PM, Xinchen Hui <larue...@php.net> wrote:
> Commit: 290509755ac4a3279b2b31b899aa9f2dd780f5f4 > Author: Xinchen Hui <larue...@php.net> Thu, 7 Feb 2013 > 23:44:46 +0800 > Parents: 0547a36e95ec36025a30e93e971d26b6b1ecf0e9 > Branches: PHP-5.5 > > Link: > http://git.php.net/?p=php-src.git;a=commitdiff;h=290509755ac4a3279b2b31b899aa9f2dd780f5f4 > > Log: > Fixed bug #64135 (Exceptions from set_error_handler are not always > propagated) > Is there any particular reason why the exception check was added only the that error branch? Can't it be done right after the GET_OP1_OBJ_ZVAL_PTR in http://lxr.php.net/xref/PHP_TRUNK/Zend/zend_vm_def.h#2442? This way it would cover the other error conditions as well. Thanks, Nikita