On Wed, Apr 3, 2013 at 4:56 PM, Johannes Schlüter <johan...@schlueters.de>wrote:
> Hi, > > On Mon, 2013-03-25 at 15:48 +0000, Xinchen Hui wrote: > > +%code requires { > > +#ifdef ZTS > > +# define YYPARSE_PARAM tsrm_ls > > +# define YYLEX_PARAM tsrm_ls > > +#endif > > +} > > + > > This doesn't seem to work with bison 2.3, either we have to increase the > bison dependency or find another fix. Bison 2.3 is default with at least > Solaris 11. > > $ bison --version > bison (GNU Bison) 2.3 > [...] > $ ./config.nice > [...] > configure:5229: checking for bison version > configure:5249: result: 2.3 (ok) > [...] > $ bison -y -p zend -v -d Zend/zend_language_parser.y -o > Zend/zend_language_parser.c > Zend/zend_language_parser.y:50.1-5: invalid directive: `%code' > Zend/zend_language_parser.y:50.7-14: syntax error, unexpected identifier > Hey: yes, %code is introduced in bison 2.3+(it is said is 2.3a) . so, maybe we need to drop supports of 2.3 in 5.5 release, or revert this fix,, wait for somethings (like one year) thanks johannes -- Laruence Xinchen Hui http://www.laruence.com/