At 00:03 23-08-01, Jeroen van Wolffelaar wrote:
>Simply committing at once with: "rewrite everything that has to do with
>rand" won't be any useful. 80% of the diff is the moving of code, and only
>20% the real change. You also don't see what changed. Just as bad as mixing
>WS fixes with real fixes.

I don't think you would get too many comments if you commit to a branch either.

What I would do in your case is:

(a) Tag the relevant files as they are today (i.e., PRE_RAND_REDESIGN or 
whatever)
(b) Commit your move-around changes
(c) Commit the real changes (can be done immediately after (b), as long as 
it's separate)
(d) Cross your fingers :)

If we like it, the tree will be fixed quite quickly.  If we don't, we can 
revert easily.
I usually don't encourage people to commit changes that break the tree, but 
as we're not anywhere near a new release (that is, 4.0.7 already branched) 
having the tree broken for a few hours or even a couple of days under the 
'less-mainstream' configurations is not a complete disaster...

Zeev


-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]

Reply via email to