ID: 14615
Updated by: hholzgra
Reported By: [EMAIL PROTECTED]
Status: Open
Bug Type: Feature/Change Request
Operating System: Windows
PHP Version: 4.1.0
New Comment:
now this is strange ...
the following snippet from php4/main/main.c
(around line 300) does the actual logging
and as it does *not* open the logfile in
binary mode it should automaticly convert
'\n' to whatever the local platform prefers???
log_file = VCWD_FOPEN(PG(error_log), "a");
if (log_file != NULL) {
time(&error_time);
strftime(error_time_str, 128
, "%d-%b-%Y %H:%M:%S"
, php_localtime_r(&error_time, &tmbuf));
fprintf(log_file, "[%s] ", error_time_str);
fprintf(log_file, "%s", log_message);
fprintf(log_file, "\n");
fclose(log_file);
return;
}
Previous Comments:
------------------------------------------------------------------------
[2001-12-20 04:36:06] [EMAIL PROTECTED]
Reopen, leave Type: to Feature Request.
------------------------------------------------------------------------
[2001-12-20 04:28:40] [EMAIL PROTECTED]
"but i'm not really sure what log we are talking about here"
I am talking about the PHP log file which can be defined with the directive "error_log
= ..." in the PHP.INI file.
------------------------------------------------------------------------
[2001-12-20 04:23:54] [EMAIL PROTECTED]
There's nothing wrong with the editor. I have used Notepad to view the PHP log.
I have also viewed the PHP log with Visual C++ which *converts* (note the word
convert) the LF to CRLF. Appearently, CRLF is the preferred format in Windows for new
lines above LF.
Besides, CRLF is the new line format which practically every editor in Windows
supports.
And besides everything: CRLF *is* the Windows newline, LF is not. So it would not make
sense to use LF as a new line in Windows environments.
------------------------------------------------------------------------
[2001-12-20 04:23:14] [EMAIL PROTECTED]
well, different systems *have* different default
line ending styles, so we might want to write
whatever is considered 'native' on a certain
platform
but i'm not really sure what log we are talking
about here, as the default log mechanism (as i
know it on Linux/Apache) is to pass log messages
to the webserver for logging?
------------------------------------------------------------------------
[2001-12-20 04:10:07] [EMAIL PROTECTED]
Your sentence doesn't compute: "[...] but Windows only recognizes ASCII 13 + ASCII 10
(CRLF) as a new line.". You mean, your editor is broken and does not support it.
No bug, bogusifying.
------------------------------------------------------------------------
The remainder of the comments for this report are too long. To view
the rest of the comments, please view the bug report online at
http://bugs.php.net/?id=14615
Edit this bug report at http://bugs.php.net/?id=14615&edit=1
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
To contact the list administrators, e-mail: [EMAIL PROTECTED]
