this would be nice to have - I've written some code for that a while 
back, but never got to finishing or committing it, so it's all abandoned 
now.

I briefly looked at your code and have a couple of comments. First, 
writing to dbase is optional for most people (because it's not safe to 
write from multiple instances of PHP running, and you are just asking 
for trouble that way anyway) but reading from it is, indeed, useful to 
retrieve some legacy data.

for starters, it would be nice to have dbase_open(), dbase_close() (they 
should probably check dbf_dhead.dbh_dbt - see dbf.h - this field already 
gets filled when you do dbase_open() on a file).

...which brings me to another question - you are using .fpt extension 
for memo files, right? wasn't it .dbt or something like that? I have a 
nagging suspicion that .fpt is what FoxPro decided to use, and everyone 
else uses something else.

after that some read-only support would be nice (dbase_get_record() / 
dbase_get_record_with_names() pair).

after that's ready, we can add some write support, but when it's added 
it would be nice to add changes to dbase_add_record() together with 
changes to dbase_delete_record() and dbase_pack(). It's sad if we can 
add but not delete. I'd rather have read-only access than a handicapped 
write access.

If you submit a unified diff against the HEAD branch to this list, 
chances are someone will add it (as long as it  does not obviously break 
things for other people).

Those are just a few thoughts...

Vlad


Geoff wrote:

>I've enhanced Jim Winstead's dbase extension about a year ago by adding
>[some] memo support. Over time have kept it up to date with the latest PHP
>distribution.  I've recently migrated this code into the PHP 4.2.1 release.
>What I'd like is to have my code placed in the default PHP distribution, so
>that I don't have to keep going back to make changes.
>
>Currently, my enhancements support dbase_create() and dbase_add_record() to
>allow for the insertion of non-binary memo data.  I'm close to having the
>dbase_get_record() function returning memo data aswell; but this still needs
>to be migrated to 4.2.1 before I can complete it.
>
>So, how do I get my enhanced code into the regular PHP distribution?
>Whatever needs to be done, please let me know.
>
>In the meantime, if you are interested in the dbase module, you can get it
>from http://www.jukeware.com/projects.php?id=1
>After a bit more testing, I'll have the 4.2.1 migrated code there.
>
>Thanks,
>Geoff Jukema
>
>
>
>
>


-- 

-- 
Vlad Krupin
Software Engineer
echospace.com




-- 
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php

Reply via email to