I was just thinking that .phps support is there to
just show source of some php file. I don't think it's
really any BC problem to always have line numbering on
for them. And have an optional parameter to the PHP function
to show those numbers if wanted.
I don't understand what's the big deal about this thing anyway?
It's nice new feature.
--Jani
p.s. Sorry for stepping into this discussion without reading past mails. :)
On Wed, 18 Sep 2002, Devon O'Dell wrote:
>Considering I've written this, I think I've done the research. You
>*don't* configure x-application/x-httpd-php-source-with-line-number
>or whatever. When you view the .phps (or .php script with
>highlight_file()), if you have accessed the page with a trailing
>?HIGHLIGHT_FORMAT=lineno, you get line numbers. This was
>the general consensus of how this feature should work if it were to
>be adopted as ini entries were frowned upon.
>
>Instead of telling me to read the source about how PHP/Zend works,
>how about pointing to where the problem is with .phps. Here's the
>code from the Apache module.
>
> if (display_source_mode) {
> zend_syntax_highlighter_ini syntax_highlighter_ini;
>
> php_get_highlight_struct(&syntax_highlighter_ini);
> if (highlight_file(SG(request_info).path_translated,
>&syntax_highlighter_ini TSRMLS_CC)){
> return OK;
> } else {
> return NOT_FOUND;
> }
> } else {
> file_handle.type = ZEND_HANDLE_FILENAME;
> file_handle.handle.fd = 0;
> file_handle.filename = SG(request_info).path_translated;
> file_handle.opened_path = NULL;
> file_handle.free_filename = 0;
>
> (void) php_execute_script(&file_handle TSRMLS_CC);
> }
>
>If it is a phps, run highlight_file. Theoretically, there is absolutely
>no difference between highlight_file and a .phps script. If not,
>execute the script.
>
>To illustrate this, we'll jump into the PHP_FUNCTION(highlight_file)
>which calls highlight_file() with the filename and ini config struct.
>This function is defined in zend_language_scanner.l, opens the
>file for scanning, and sends control to zend_highlight() which does
>the rest.
>
>It's the same thing.
>
>Just to be fair, I'd ask what people are thinking about this "feature"
>now, is anyone else still +anything about it? Additionally, if you
>are + about it, is the ?HIGHLIGHT_FORMAT check decent?
>
>Devon
>
>Yasuo Ohgaki wrote:
>
>> This msg may be sent twice....
>>
>> Devon O'Dell wrote:
>> > I wonder if you understand that highligh_file() *is* a call to the
>> > *same* function that provides .phps files with functionality.
>> > By adding line numbers to this function, we are automatically
>> > adding them to .phps free of charge. Doesn't break anything or
>> > make anything less secure.
>> >
>> > The only security implications of .phps are user related and are
>> > also inherent in files shown with highlight_file.
>> > I *really* have no clue about why you say it's half broken. It
>>
>> Read source and understand how things are sent from PHP/Zend,
>> research issues related to it. IIRC there should be at least one bug
>> report in what condition phps does not work well.
>>
>> I vote -1 for changing/adding phps feature.
>> In other words, no x-application/x-httpd-php-source-with-line-number or
>> like.
>>
>> BTW, if you would like to add extra option to highlight_file(), etc.
>> My vote is 0. People should use highlight_file() instead of phps,
>> anyway. With PHP level, we can forget all issues related to phps.
>>
>>
>> > works fine (except for that extra line number thing, but that's no
>> > real problem I'm sure -- the extra line number is also *not*
>> > evident in files highlighted by highlight_file() as I don't think
>> > you understood) and, if it is not supported by your host, a simple
>> > call to highlight_file() is the *exact same thing*.
>> >
>> > Nowhere in my code is there a regex.
>>
>> It's not the point, user can do that if they would like to add line
>> numbers.
>>
>> I really don't care much about this issue wheather there is yet
>> another half broken phps with
>> x-application/x-httpd-php-source-with-line-number, I'm just suggesting
>> having one more half broken feature is not nice.
>>
>> >
>> > I mean, use highlight_file or .phps or whatever, you're advocating
>> > the use of the *exact same functions* in the end. They all
>> > eventually break down to zend_highlight().
>>
>> It's not about the issue calling the same function eventually or not.
>>
>> Again,
>>
>> Research how things should be sent from PHP/Zend. With PHP level, e.g.
>> with scripting, we can forget all issues related to phps.
>>
>> --
>> Yasuo Ohgaki
>
>
>
>
--
<- For Sale! ->
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
