On Sunday 29 September 2002 23:14, Sascha Schumann wrote: [snip] > Well, the install target did not work, because you > made no visible effort to integrate your SAPI module with the > rest of PHP.
Yes I made no effort to integrate SAPI into the "make install" chain as I was not quite sure what was the best thing to do. Hence my question to php-dev. > > Your comments to Derick make very little sense to me. We have a bunch of > > I would hope for input from your side regarding what > requirements your SAPI module has (e.g. whether it makes > sense to have a separate SAPI class for it). Such a > conversation could have taken place before the commit, but > it is not too late to commence that dialogue now. Ok. Let's commence the dialogue. I think a separate SAPI class is warranted because after your changes you would need to recompile PHP 3 times to get what was possible with a separate class. Once for SAPI + cli, once for libphp.a, and once for libphp.so. If we had PHP_LIB_OBJS group it would be possible to add a new "LIB" target to both build and install stages. That class should consist of sapi/embed/php_embed.c and main/internal_functions.c. Then it should be possible to link the libs at the same cli and main sapi link is done. Hope this clarifies what I had in mind. Edin -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
