At 10:47 PM 10/9/2002 +0200, Sterling Hughes wrote: >On Wed, 2002-10-09 at 22:45, Derick Rethans wrote: > > On 9 Oct 2002, Sterling Hughes wrote: > > > > > On Wed, 2002-10-09 at 22:21, Thies C. Arntzen wrote: > > > > On Wed, Oct 09, 2002 at 06:29:45PM -0000, Sterling Hughes wrote: > > > > > sterling Wed Oct 9 14:29:45 2002 EDT > > > > > > > > > > Modified files: > > > > > /php4/ext/standard array.c > > > > > Log: > > > > > clean these functions up using zend_parse_parameters and nuke > the use of > > > > > HASH_OF() which is inappropriate in these cases... > > > > > > > > will prev still work on objects after your patch? > > > > > > > > > > none of them do - none of them should either - why would you want to > > > access an object like you would an _indexed_ array? > > > > It breaks BC, soooo... revert? (Not that I see any use either :) > > If you're at it, please add some tests for the test framework too. > > > >Well, it breaks it in a "not-really-breaking-bc-manner." To my >knowledge this was never documented to work. I don't think anyone will >miss this feature - if someone will, and is/has used it, please write in >and let me know, the patch can be modified to work on objects. But then >again, it really wouldn't work well on objects anyhow (even before my >patch), so i really don't see the point.
Why wouldn't it work well? HASH_OF() was always used when the intention was for it to work for both arrays and objects. Also, I doubt the php-cvs nor the php-dev forums can let you know if this feature is being used. You'd have to ask all of the PHP users out there. Andi -- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
