The following fixes the memory leak of domxml002.phpt test. marcus
cvs -z3 -q diff php_domxml.c (in directory S:\php4-HEAD\ext\domxml\) Index: php_domxml.c =================================================================== RCS file: /repository/php4/ext/domxml/php_domxml.c,v retrieving revision 1.215 diff -u -r1.215 php_domxml.c --- php_domxml.c 29 Oct 2002 16:45:19 -0000 1.215 +++ php_domxml.c 29 Oct 2002 16:49:08 -0000 @@ -572,7 +572,7 @@ zval *wrapper; int refcount = 0; /* FIXME: type check probably unnecessary here? */ - if (!node || Z_TYPE_P(node) == XML_DTD_NODE) + if (!node) /* || Z_TYPE_P(node) == XML_DTD_NODE)*/ return; wrapper = dom_object_get_data(node);