I could do the autoconf stuff and i vould go for naming all these function dns_get_xx() and such.
marcus At 12:38 17.11.2002, Derick Rethans wrote:
On Sun, 17 Nov 2002 [EMAIL PROTECTED] wrote:
> Hello,
>
> Who can commit that now?
I don't think it's ready yet. I agree with Marcus that the name of the
function should be different then getanyrr(), it definitely doesn't fit
into the naming things we have (with that getmxrr() doesn't fit either).
I also think that the selection of the type of record to fetch should be
made a constant so that we don't need to strncasecmp it everytime, and I
would favor an implementation with zend_parse_parameters() to get rid of
the (IMO) ugly parameter handling.
Also, a lot of lines don't follow coding standards, like:
n = res_nmkquery(&res,QUERY,Z_STRVAL_P(host),C_IN,type_to_fetch,NULL,0,NULL,buf.qb2,sizeof buf);
instead of:
n = res_nmkquery(&res, QUERY, Z_STRVAL_P(host), C_IN, type_to_fetch, NULL, 0, NULL, buf.qb2, sizeof(buf));
And I miss autoconf checks for all those DNS functions (like
res_mkquery, dn_expand) which might not exist on all platforms.
regards,
Derick
> "Marcus Börger" <[EMAIL PROTECTED]> a écrit dans le message de
> news: [EMAIL PROTECTED]
> > Function is nice but the function name is not.
> > Attached is a second revised patch that fixes the build problems.
> >
> > marcus
> >
> > At 00:11 17.11.2002, Pollita wrote:
> > >Per corrections suggested by [EMAIL PROTECTED], attached is a revised pacth
> to
> > >ext/standard/dns.c for addition of getanyrr() function.
> > >
> > >
> > >--
> > >PHP Development Mailing List <http://www.php.net/>
> > >To unsubscribe, visit: http://www.php.net/unsub.php
> >
>
>
>
> --
> PHP Development Mailing List <http://www.php.net/>
> To unsubscribe, visit: http://www.php.net/unsub.php
>
--
---------------------------------------------------------------------------
Derick Rethans http://derickrethans.nl/
JDI Media Solutions
--------------[ if you hold a unix shell to your ear, do you hear the c? ]-
--
PHP Development Mailing List <http://www.php.net/>
To unsubscribe, visit: http://www.php.net/unsub.php
-- PHP Development Mailing List <http://www.php.net/> To unsubscribe, visit: http://www.php.net/unsub.php
